Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 475223004: Add the BUILD files for content_resources. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, darin (slow to review), jam, jochen (gone - plz use gerrit), pilgrim_google, jamesr
Project:
chromium
Visibility:
Public.

Description

Add the BUILD files for content_resources. - Add GN build file (BUILD.gn) for content_resources target (//content/app/resources). - Add GRD file for grit (content_resources.grd). - Add GYP file (content_resources.gyp) to generate the grit header file from content_resources.grd Not hooked up yet, this will come in the next CL. BUG=338338 TEST=None R=avi@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290150

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
A + content/app/resources/BUILD.gn View 1 chunk +4 lines, -3 lines 1 comment Download
A + content/app/resources/content_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/app/resources/content_resources.gyp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 4 months ago (2014-08-16 03:41:59 UTC) #1
Avi (use Gerrit)
lgtm I'm not a build file expert, but this looks plausible.
6 years, 4 months ago (2014-08-16 04:25:50 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-16 14:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/475223004/1
6 years, 4 months ago (2014-08-16 14:33:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 290150
6 years, 4 months ago (2014-08-16 14:42:47 UTC) #5
Nico
6 years, 4 months ago (2014-08-20 15:41:10 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/475223004/diff/1/content/app/resources/BUILD.gn
File content/app/resources/BUILD.gn (right):

https://codereview.chromium.org/475223004/diff/1/content/app/resources/BUILD....
content/app/resources/BUILD.gn:8: source = "content_resources.grd"
Why does this rule exist both here and in content/BUILD.gn ?

Powered by Google App Engine
This is Rietveld 408576698