pkg/analysis_server/tool/spec/codegen_matchers.dart - Issue 475143003: Fix code generated matchers to handle recursive objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/tool/spec/codegen_matchers.dart

Issue 475143003: Fix code generated matchers to handle recursive objects. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/tool/spec/codegen_matchers.dart

diff --git a/pkg/analysis_server/tool/spec/codegen_matchers.dart b/pkg/analysis_server/tool/spec/codegen_matchers.dart

index 74c76dbdd3880984cc41d8f385dde09dccd7e006..07a1b68961f2e2376fb4bba3acebdc5f5a3eede2 100644

--- a/pkg/analysis_server/tool/spec/codegen_matchers.dart

+++ b/pkg/analysis_server/tool/spec/codegen_matchers.dart

@@ -136,7 +136,7 @@ class CodegenMatchersVisitor extends HierarchicalApiVisitor with CodeGenerator {

@override

void visitTypeObject(TypeObject typeObject) {

- writeln('new MatchesJsonObject(');

+ writeln('new LazyMatcher(() => new MatchesJsonObject(');

indent(() {

write('${JSON.encode(context)}, ');

Iterable<TypeObjectField> requiredFields = typeObject.fields.where(

@@ -149,7 +149,7 @@ class CodegenMatchersVisitor extends HierarchicalApiVisitor with CodeGenerator {

outputObjectFields(optionalFields);

}

});

- write(')');

+ write('))');

}

/**

« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | no next file » | no next file with comments »