chrome/browser/policy/policy_service_impl_unittest.cc - Issue 47513018: Make the internal storage of policy::Schemas ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_service_impl_unittest.cc

Issue 47513018: Make the internal storage of policy::Schemas ref counted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-4-new-generate

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/policy_domain_descriptor_unittest.cc ('k') | chrome/common/extensions/api/storage/storage_schema_manifest_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_service_impl_unittest.cc

diff --git a/chrome/browser/policy/policy_service_impl_unittest.cc b/chrome/browser/policy/policy_service_impl_unittest.cc

index c7854d5333d9e33d65b79fbefd56306bfb56fecb..a02f38f30d6d5f0d1cb0e910acee817991d35c5c 100644

--- a/chrome/browser/policy/policy_service_impl_unittest.cc

+++ b/chrome/browser/policy/policy_service_impl_unittest.cc

@@ -627,7 +627,7 @@ TEST_F(PolicyServiceTest, RegisterPolicyDomain) {

// Register another namespace.

std::string error;

- scoped_ptr<SchemaOwner> schema = SchemaOwner::Parse(

+ Schema schema = Schema::Parse(

"{"

" \"type\":\"object\","

" \"properties\": {"

@@ -639,10 +639,10 @@ TEST_F(PolicyServiceTest, RegisterPolicyDomain) {

" \"String\": { \"type\": \"string\" }"

" }"

"}", &error);

- ASSERT_TRUE(schema);

+ ASSERT_TRUE(schema.valid()) << error;

scoped_refptr<PolicyDomainDescriptor> extensions_descriptor =

new PolicyDomainDescriptor(POLICY_DOMAIN_EXTENSIONS);

- extensions_descriptor->RegisterComponent(kExtension, schema.Pass());

+ extensions_descriptor->RegisterComponent(kExtension, schema);

EXPECT_CALL(provider0_, RegisterPolicyDomain(

scoped_refptr<const PolicyDomainDescriptor>(extensions_descriptor)));

policy_service_->RegisterPolicyDomain(extensions_descriptor);