chrome/browser/policy/generate_policy_source_unittest.cc - Issue 47513018: Make the internal storage of policy::Schemas ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/generate_policy_source_unittest.cc

Issue 47513018: Make the internal storage of policy::Schemas ref counted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-4-new-generate

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/component_cloud_policy_service_unittest.cc ('k') | chrome/browser/policy/policy_domain_descriptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/generate_policy_source_unittest.cc

diff --git a/chrome/browser/policy/generate_policy_source_unittest.cc b/chrome/browser/policy/generate_policy_source_unittest.cc

index 174b486f0fedbc1216045c60bd45ada824bf0bca..c82341036e5aa7302eb58c6a9a6681941d9f6891 100644

--- a/chrome/browser/policy/generate_policy_source_unittest.cc

+++ b/chrome/browser/policy/generate_policy_source_unittest.cc

@@ -16,11 +16,8 @@

namespace policy {

TEST(GeneratePolicySource, ChromeSchemaData) {

- scoped_ptr<SchemaOwner> schema_owner =

- SchemaOwner::Wrap(GetChromeSchemaData());

- ASSERT_TRUE(schema_owner);

- Schema schema = schema_owner->schema();

+ Schema schema = Schema::Wrap(GetChromeSchemaData());

+ ASSERT_TRUE(schema.valid());

EXPECT_EQ(base::Value::TYPE_DICTIONARY, schema.type());

Schema subschema = schema.GetAdditionalProperties();