Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler.h

Issue 47513018: Make the internal storage of policy::Schemas ref counted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-4-new-generate
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler.h b/chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
index d2406d615c4d624a928551ed10f62242ce138911..d3d5b3be628483e5f7459f4d96dc7957063ce622 100644
--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
@@ -9,7 +9,7 @@
#include "chrome/common/extensions/manifest_handler.h"
namespace policy {
-class SchemaOwner;
+class Schema;
}
namespace extensions {
@@ -21,11 +21,10 @@ class StorageSchemaManifestHandler : public ManifestHandler {
virtual ~StorageSchemaManifestHandler();
// Returns the managed storage schema defined for |extension|.
- // If the schema is invalid then NULL is returned, and the failure reason
- // is stored in |error|.
+ // If the schema is invalid then the failure reason is stored in |error|.
dconnelly 2013/10/29 16:43:58 mention what is returned if it's invalid
Joao da Silva 2013/10/29 20:38:42 Done.
// This function does file I/O and must be called on a thread that allows I/O.
- static scoped_ptr<policy::SchemaOwner> GetSchema(const Extension* extension,
- std::string* error);
+ static policy::Schema GetSchema(const Extension* extension,
+ std::string* error);
private:
// ManifestHandler implementation:

Powered by Google App Engine
This is Rietveld 408576698