More Windows 64b compilation warning fixes

More Windows 64b compilation warning fixes

[bsalomon, 2013-10-29 14:40:36]

https://codereview.chromium.org/47513017/diff/30001/include/core/SkUtils.h
File include/core/SkUtils.h (right):

https://codereview.chromium.org/47513017/diff/30001/include/core/SkUtils.h#ne...
include/core/SkUtils.h:82: size_t SkUTF16_ToUTF8(const uint16_t utf16[], size_t
numberOf16BitValues,
not sure about this.

https://codereview.chromium.org/47513017/diff/30001/src/core/SkUtils.cpp
File src/core/SkUtils.cpp (left):

https://codereview.chromium.org/47513017/diff/30001/src/core/SkUtils.cpp#oldc...
src/core/SkUtils.cpp:373: size_t SkUTF16_ToUTF8(const uint16_t utf16[], int
numberOf16BitValues,
not sure about this one

https://codereview.chromium.org/47513017/diff/30001/src/gpu/GrTHashTable.h
File src/gpu/GrTHashTable.h (right):

https://codereview.chromium.org/47513017/diff/30001/src/gpu/GrTHashTable.h#ne...
src/gpu/GrTHashTable.h:62: static unsigned hash2Index(intptr_t hash) {
really?

https://codereview.chromium.org/47513017/diff/30001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/gpu/SkGpuDevice.cpp#n...
src/gpu/SkGpuDevice.cpp:597: static_cast<int>(count),
SkCanvas:: and SkDevice::drawPoints should probably take int count, but ok.
SkToS32?

https://codereview.chromium.org/47513017/diff/30001/src/gpu/gl/GrGLProgramDes...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/gpu/gl/GrGLProgramDes...
src/gpu/gl/GrGLProgramDesc.cpp:108: *desc->atOffset<uint32_t, kLengthOffset>() =
static_cast<uint32_t>(newKeyLength);
SkToU32 adds an assert in debug

https://codereview.chromium.org/47513017/diff/30001/src/pdf/SkPDFDeviceFlatte...
File src/pdf/SkPDFDeviceFlattener.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/pdf/SkPDFDeviceFlatte...
src/pdf/SkPDFDeviceFlattener.cpp:46: d.fMatrix->mapPoints(flattenedPoints,
points, static_cast<int>(count));
SkToS32

[robertphillips, 2013-11-18 20:22:41]

PTAL

https://codereview.chromium.org/47513017/diff/30001/include/core/SkUtils.h
File include/core/SkUtils.h (right):

https://codereview.chromium.org/47513017/diff/30001/include/core/SkUtils.h#ne...
include/core/SkUtils.h:82: size_t SkUTF16_ToUTF8(const uint16_t utf16[], size_t
numberOf16BitValues,
On 2013/10/29 14:40:36, bsalomon wrote:
> not sure about this.

Done.

https://codereview.chromium.org/47513017/diff/30001/src/core/SkUtils.cpp
File src/core/SkUtils.cpp (left):

https://codereview.chromium.org/47513017/diff/30001/src/core/SkUtils.cpp#oldc...
src/core/SkUtils.cpp:373: size_t SkUTF16_ToUTF8(const uint16_t utf16[], int
numberOf16BitValues,
On 2013/10/29 14:40:36, bsalomon wrote:
> not sure about this one

Done.

https://codereview.chromium.org/47513017/diff/30001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/gpu/SkGpuDevice.cpp#n...
src/gpu/SkGpuDevice.cpp:597: static_cast<int>(count),
On 2013/10/29 14:40:36, bsalomon wrote:
> SkCanvas:: and SkDevice::drawPoints should probably take int count, but ok.
> SkToS32?

Done.

I would also like to change SkCanvas:: & SkDevice to take an int for drawPoints
but that should probably be a CL of its own.

https://codereview.chromium.org/47513017/diff/30001/src/gpu/gl/GrGLProgramDes...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/gpu/gl/GrGLProgramDes...
src/gpu/gl/GrGLProgramDesc.cpp:108: *desc->atOffset<uint32_t, kLengthOffset>() =
static_cast<uint32_t>(newKeyLength);
On 2013/10/29 14:40:36, bsalomon wrote:
> SkToU32 adds an assert in debug

Done.

https://codereview.chromium.org/47513017/diff/30001/src/pdf/SkPDFDeviceFlatte...
File src/pdf/SkPDFDeviceFlattener.cpp (right):

https://codereview.chromium.org/47513017/diff/30001/src/pdf/SkPDFDeviceFlatte...
src/pdf/SkPDFDeviceFlattener.cpp:46: d.fMatrix->mapPoints(flattenedPoints,
points, static_cast<int>(count));
On 2013/10/29 14:40:36, bsalomon wrote:
> SkToS32

Done.

[bsalomon, 2013-11-20 15:23:47]

lgtm

[robertphillips, 2013-11-20 15:46:44]

committed at 12315

[robertphillips, 2013-11-20 15:56:46]

Reverted in r12316 (due to compilation errors)

[robertphillips, 2013-11-21 14:24:33]

commited again as r12337