[PPAPI] Add target param for CompositorLayer::SetTexture().

[PPAPI] Add target param for CompositorLayer::SetTexture().

BUG=403504
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290016

[Peng, 2014-08-14 19:38:08]

Hi Bill & Tom, PTAL. Thanks.

[bbudge, 2014-08-14 19:47:13]

Do we need to worry about versioning this?

[Peng, 2014-08-14 19:58:50]

On 2014/08/14 19:47:13, bbudge wrote:
> Do we need to worry about versioning this?
I think we are the only user of this API right now, and we don't release
anything yet. So I think we don't need about it. right?

[bbudge, 2014-08-14 19:59:17]

LGTM then

[Tom Sepez, 2014-08-14 21:34:42]

Messages LGTM.

[bbudge, 2014-08-15 17:10:11]

https://codereview.chromium.org/475123003/diff/40001/ppapi/cpp/compositor_lay...
File ppapi/cpp/compositor_layer.cc (right):

https://codereview.chromium.org/475123003/diff/40001/ppapi/cpp/compositor_lay...
ppapi/cpp/compositor_layer.cc:69: return cc.MayForce(PP_ERROR_BADARGUMENT);
I think PP_ERROR_NOTSUPPORTED is more appropriate here. See
ppapi/cpp/file_ref.cc for example.

I realize it's quite tedious, but in general, when there's a new version of the
API, we check for version for every method in the class. So you need to do this
'has_interface' and 'get_interface' logic for every method in this file.

[Peng, 2014-08-15 17:58:45]

Addressed issues. PTAL. Thanks.

https://codereview.chromium.org/475123003/diff/40001/ppapi/cpp/compositor_lay...
File ppapi/cpp/compositor_layer.cc (right):

https://codereview.chromium.org/475123003/diff/40001/ppapi/cpp/compositor_lay...
ppapi/cpp/compositor_layer.cc:69: return cc.MayForce(PP_ERROR_BADARGUMENT);
On 2014/08/15 17:10:11, bbudge wrote:
> I think PP_ERROR_NOTSUPPORTED is more appropriate here. See
> ppapi/cpp/file_ref.cc for example.
> 
> I realize it's quite tedious, but in general, when there's a new version of
the
> API, we check for version for every method in the class. So you need to do
this
> 'has_interface' and 'get_interface' logic for every method in this file.

Done.

[bbudge, 2014-08-15 18:03:15]

LGTM again

[Peng, 2014-08-15 18:04:35]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2014-08-15 18:06:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/penghuang@chromium.org/475123003/60001

[commit-bot: I haz the power, 2014-08-15 21:30:21]

Committed patchset #4 (60001) as 290016