Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: sdk/lib/_internal/pub/lib/src/package.dart

Issue 475093003: Precompile immutable globally-installed pub executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/package.dart
diff --git a/sdk/lib/_internal/pub/lib/src/package.dart b/sdk/lib/_internal/pub/lib/src/package.dart
index 211eb37e6a1de862d7c030b152014e9af64bcc37..3dd84e2d253facf02d1f199f47644495037b39df 100644
--- a/sdk/lib/_internal/pub/lib/src/package.dart
+++ b/sdk/lib/_internal/pub/lib/src/package.dart
@@ -7,6 +7,7 @@ library pub.package;
import 'dart:io';
import 'package:path/path.dart' as path;
+import 'package:barback/barback.dart';
import 'io.dart';
import 'git.dart' as git;
@@ -75,6 +76,20 @@ class Package {
return deps.values.toSet();
}
+ /// Returns a list of asset ids for all Dart executables in this package's bin
+ /// directory.
+ List<AssetId> get executableIds {
+ var binDir = path.join(dir, 'bin');
+ if (!dirExists(binDir)) return [];
+
+ return ordered(listFiles(beneath: binDir, recursive: false))
+ .where((executable) => path.extension(executable) == '.dart')
+ .map((executable) {
+ return new AssetId(
+ name, path.toUri(path.relative(executable, from: dir)).toString());
+ }).toList();
+ }
+
/// Returns the path to the README file at the root of the entrypoint, or null
/// if no README file is found.
///
@@ -154,7 +169,13 @@ class Package {
// If we're not listing recursively, strip out paths that contain
// separators. Since git always prints forward slashes, we always detect
// them.
- if (!recursive) files = files.where((file) => !file.contains('/'));
+ if (!recursive) {
+ // If we're listing a subdirectory, we only want to look for slashes
+ // after the subdirectory prefix.
+ var relativeStart = relativeBeneath == '.' ? 0 :
+ relativeBeneath.length + 1;
+ files = files.where((file) => !file.contains('/', relativeStart));
+ }
// Git always prints files relative to the repository root, but we want
// them relative to the working directory. It also prints forward slashes

Powered by Google App Engine
This is Rietveld 408576698