Issue 475073002: DevTools: normalize sourceURL paths in importScript function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 475073002: DevTools: normalize sourceURL paths in importScript function (Closed)

Created:
6 years, 4 months ago by lushnikov

Modified:
6 years, 4 months ago

Reviewers:
apavlov, vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: normalize sourceURL paths in importScript function Currently, importScript function gets scripts to load which contain "../" in their path. These are written in their sourceURL's, but they should be actually normalized to match network resource. R=vsevik, apavlov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180355

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -34 lines)			Patch
	M	Source/devtools/front_end/Runtime.js	View		2 chunks	+35 lines, -0 lines	0 comments	Download
	M	Source/devtools/front_end/common/ParsedURL.js	View		2 chunks	+1 line, -34 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/475073002/1

6 years, 4 months ago (2014-08-15 10:52:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180355

Expand Messages | Collapse Messages