IndexedDB + Coding Style: re-order enums/typedefs/... to match guide

IndexedDB + Coding Style: re-order enums/typedefs/... to match guide

BUG=381456
R=cmumford@chromium.org

Committed: https://crrev.com/0a918e69c0d6ff5395ad10b84e738e9e5574010c
Cr-Commit-Position: refs/heads/master@{#291585}

[cmumford, 2014-08-20 19:43:06]

lgtm with nit level questions.

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_blob_info.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_blob_info.h:37: ~IndexedDBBlobInfo();
Should this be reordered in the *.cc file too?

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_database.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_database.h:229: class PendingDeleteCall;
Should these be in alphabetical order?

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_dispatcher_host.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_dispatcher_host.h:110: typedef
std::map<int64, GURL> TransactionIDToURLMap;
alphabetical?

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_leveldb_coding.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_leveldb_coding.h:401: static const int64
kSpecialIndexNumber;
Unrelated to your change, but can be private? Same for two other special index
number constants?

[jsbell, 2014-08-22 20:50:01]

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_blob_info.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_blob_info.h:37: ~IndexedDBBlobInfo();
On 2014/08/20 19:43:05, cmumford wrote:
> Should this be reordered in the *.cc file too?

Done.

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_database.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_database.h:229: class PendingDeleteCall;
On 2014/08/20 19:43:05, cmumford wrote:
> Should these be in alphabetical order?

Done.

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_dispatcher_host.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_dispatcher_host.h:110: typedef
std::map<int64, GURL> TransactionIDToURLMap;
On 2014/08/20 19:43:05, cmumford wrote:
> alphabetical?

Hrm... well, I went ahead and sorted these lines by the typedef name. But they
could also be sorted as whole lines. Not sure it's a huge win, but whatever.

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_leveldb_coding.h (right):

https://codereview.chromium.org/475063004/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_leveldb_coding.h:401: static const int64
kSpecialIndexNumber;
On 2014/08/20 19:43:05, cmumford wrote:
> Unrelated to your change, but can be private? Same for two other special index
> number constants?

Compiler says... 2/3 can be made private, another is used in a DCHECK, so
leaving it alone.

[jsbell, 2014-08-22 20:50:07]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-08-22 20:50:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/475063004/20001

[jsbell, 2014-08-22 20:50:59]

The CQ bit was unchecked by jsbell@chromium.org

[jsbell, 2014-08-22 20:52:27]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-08-22 20:53:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/475063004/40001

[commit-bot: I haz the power, 2014-08-22 21:04:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45368)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50553)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 21:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 21:06:40]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45373)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jsbell, 2014-08-22 23:16:47]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-08-22 23:17:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/475063004/60001

[commit-bot: I haz the power, 2014-08-23 05:52:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-23 21:36:03]

Committed patchset #4 (60001) as d76f28db72356458d5a2d49eda4850104758c7a9

[commit-bot: I haz the power, 2014-09-10 02:31:08]

Patchset 4 (id:??) landed as
https://crrev.com/0a918e69c0d6ff5395ad10b84e738e9e5574010c
Cr-Commit-Position: refs/heads/master@{#291585}