Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 475063002: Remove no-op FLAKY_ prefix from BrowsingDataRemovalMask test (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove no-op FLAKY_ prefix from BrowsingDataRemovalMask test This prefix was added in https://src.chromium.org/viewvc/chrome?revision=207246&view=revision, and even then it was a no-op. Despite the no-op-ness, the test flakiness was fixed over a year ago (see bug). Now the prefix serves only to it only serves to confuse sheriff-o-matic. BUG=251742 TBR=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 4 months ago (2014-08-14 16:38:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/475063002/1
6 years, 4 months ago (2014-08-14 16:39:58 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 17:24:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 289631

Powered by Google App Engine
This is Rietveld 408576698