Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 475033002: scheduler: Shut down the scheduler before terminating the heap (Closed)

Created:
6 years, 4 months ago by Sami
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

scheduler: Shut down the scheduler before terminating the heap Shut down the scheduler before terminating the heap (i.e., PartitionAlloc). This is needed because the scheduler makes heap allocations that need to be freed at destruction time. BUG=391005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180295

Patch Set 1 #

Patch Set 2 : Need to do this after CoreInitializer because of background parsing. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebKit.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Sami
6 years, 4 months ago (2014-08-14 16:25:22 UTC) #1
alexclarke
lgtm
6 years, 4 months ago (2014-08-14 16:33:05 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-14 17:52:19 UTC) #3
eseidel
lgtm Makes sense.
6 years, 4 months ago (2014-08-14 17:52:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/475033002/40001
6 years, 4 months ago (2014-08-14 17:52:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 17:53:11 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/web/WebKit.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-14 17:53:12 UTC) #7
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 4 months ago (2014-08-14 17:59:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/475033002/60001
6 years, 4 months ago (2014-08-14 17:59:58 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 19:54:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (60001) as 180295

Powered by Google App Engine
This is Rietveld 408576698