Issue 475023002: Use new match Functor ElementTraversal API in DOMSiblingTraversalStrategy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 475023002: Use new match Functor ElementTraversal API in DOMSiblingTraversalStrategy (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
esprehn, adamk

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use new match Functor ElementTraversal API in DOMSiblingTraversalStrategy Use new match Functor ElementTraversal API in DOMSiblingTraversalStrategy to simplify the code a bit. R=adamk@chromium.org, esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180299

Patch Set 1 #

Patch Set 2 : Fix Windows build #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -22 lines)			Patch
	M	Source/core/css/SiblingTraversalStrategies.h	View	1	5 chunks	+17 lines, -22 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/475023002/diff/20001/Source/core/css/SiblingTraversalStrategies.h File Source/core/css/SiblingTraversalStrategies.h (right): https://codereview.chromium.org/475023002/diff/20001/Source/core/css/SiblingTraversalStrategies.h#newcode51 Source/core/css/SiblingTraversalStrategies.h:51: class HasTagName { We could move this to Element.h ...

6 years, 4 months ago (2014-08-14 18:48:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/475023002/20001

6 years, 4 months ago (2014-08-14 19:20:24 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 20:40:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180299

Expand Messages | Collapse Messages