Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 474983005: rename gradients private BitmapCache to GradientBitmapCache (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
caryclark
CC:
reviews_skia.org, bungeman-skia, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rename gradients private BitmapCache to GradientBitmapCache TBR= NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/a6cac4ce3896669e1b5935def0a84b4456ec9777

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -223 lines) Patch
M gyp/effects.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
D src/effects/gradients/SkBitmapCache.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/effects/gradients/SkBitmapCache.cpp View 1 chunk +0 lines, -153 lines 0 comments Download
A + src/effects/gradients/SkGradientBitmapCache.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + src/effects/gradients/SkGradientBitmapCache.cpp View 1 7 chunks +9 lines, -9 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-21 17:16:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/474983005/20001
6 years, 4 months ago (2014-08-21 17:17:03 UTC) #2
reed1
The CQ bit was unchecked by reed@google.com
6 years, 4 months ago (2014-08-21 17:22:02 UTC) #3
reed1
6 years, 4 months ago (2014-08-21 17:44:43 UTC) #4
reed1
6 years, 4 months ago (2014-08-21 17:47:22 UTC) #5
reed1
why is chrome still complaining?
6 years, 4 months ago (2014-08-21 17:47:35 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-21 17:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/474983005/20001
6 years, 4 months ago (2014-08-21 17:50:14 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 17:50:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as a6cac4ce3896669e1b5935def0a84b4456ec9777

Powered by Google App Engine
This is Rietveld 408576698