Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 474983003: Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now t… (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move some methods from OperatorProperties into Scheduler that are only related to scheduling. Now these methods take a Node* parameter, as decisions relating floating control need distinguish not just operators but nodes. R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M src/compiler/operator-properties.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/scheduler.cc View 10 chunks +35 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-08-18 12:42:42 UTC) #1
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-18 12:49:02 UTC) #2
titzer
6 years, 4 months ago (2014-08-18 13:09:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23160 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698