Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 474953002: GetHelp cut at M38: manifest.json (Closed)

Created:
6 years, 4 months ago by cylee1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add HelpApp manifest and add 'fileSystem' to GetHelp manifest #

Patch Set 3 : Move HelpApp manifest.json to another patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/resources/chromeos/genius_app/manifest.json View 1 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
cylee1
6 years, 4 months ago (2014-08-15 11:52:07 UTC) #1
cnwan
lgtm
6 years, 4 months ago (2014-08-15 12:01:38 UTC) #2
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 4 months ago (2014-08-15 13:17:55 UTC) #3
cylee1
The CQ bit was unchecked by cylee@chromium.org
6 years, 4 months ago (2014-08-15 13:17:55 UTC) #4
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 4 months ago (2014-08-15 13:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/474953002/40001
6 years, 4 months ago (2014-08-15 13:19:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 13:19:31 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-15 13:19:32 UTC) #8
cylee1
+ Nikita committer approval needed. Thanks
6 years, 4 months ago (2014-08-15 16:35:31 UTC) #9
Dmitry Polukhin
lgtm
6 years, 4 months ago (2014-08-18 10:13:58 UTC) #10
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 4 months ago (2014-08-18 10:36:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/474953002/40001
6 years, 4 months ago (2014-08-18 10:37:21 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (40001) as 290237
6 years, 4 months ago (2014-08-18 12:32:35 UTC) #13
cylee1
6 years, 4 months ago (2014-08-19 09:20:46 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/485013002/ by cylee@chromium.org.

The reason for reverting is: According to Dmitry, we should not have persist
background page..

Powered by Google App Engine
This is Rietveld 408576698