Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 474943002: Fix for LinkedHashSet::swap. (Closed)

Created:
6 years, 4 months ago by zerny-chromium
Modified:
6 years, 4 months ago
Reviewers:
Erik Corry
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-wtf_chromium.org, Mikhail, abarth-chromium, oilpan-reviews
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 2

Patch Set 3 : templated test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1 line) Patch
M Source/wtf/LinkedHashSet.h View 2 chunks +25 lines, -1 line 0 comments Download
M Source/wtf/ListHashSetTest.cpp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zerny-chromium
6 years, 4 months ago (2014-08-14 10:46:55 UTC) #1
Erik Corry
LGTM https://codereview.chromium.org/474943002/diff/20001/Source/wtf/ListHashSetTest.cpp File Source/wtf/ListHashSetTest.cpp (right): https://codereview.chromium.org/474943002/diff/20001/Source/wtf/ListHashSetTest.cpp#newcode659 Source/wtf/ListHashSetTest.cpp:659: TEST(ListHashSetTest, Swap) I think it makes sense to ...
6 years, 4 months ago (2014-08-14 11:06:12 UTC) #2
zerny-chromium
Good point. I've templated the test. https://codereview.chromium.org/474943002/diff/20001/Source/wtf/ListHashSetTest.cpp File Source/wtf/ListHashSetTest.cpp (right): https://codereview.chromium.org/474943002/diff/20001/Source/wtf/ListHashSetTest.cpp#newcode659 Source/wtf/ListHashSetTest.cpp:659: TEST(ListHashSetTest, Swap) On ...
6 years, 4 months ago (2014-08-14 11:14:55 UTC) #3
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 4 months ago (2014-08-14 11:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/474943002/40001
6 years, 4 months ago (2014-08-14 11:17:23 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 14:29:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180257

Powered by Google App Engine
This is Rietveld 408576698