- Account for number of pending tasks in old-space collections.

runtime/vm/thread_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "vm/thread.h"
 
 #include <errno.h>  // NOLINT
 #include <sys/time.h>  // NOLINT
 
 #include "platform/assert.h"
+#include "vm/isolate.h"
 
 namespace dart {
 
 #define VALIDATE_PTHREAD_RESULT(result) \
   if (result != 0) { \
     const int kBufferSize = 1024; \
     char error_message[kBufferSize]; \
     strerror_r(result, error_message, kBufferSize); \
     FATAL2("pthread error: %d (%s)", result, error_message); \
   }
@@ skipping 161 matching lines @@
   result = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ERRORCHECK);
   VALIDATE_PTHREAD_RESULT(result);
 #endif  // defined(DEBUG)
 
   result = pthread_mutex_init(data_.mutex(), &attr);
   // Verify that creating a pthread_mutex succeeded.
   VALIDATE_PTHREAD_RESULT(result);
 
   result = pthread_mutexattr_destroy(&attr);
   VALIDATE_PTHREAD_RESULT(result);
+
+  // When running with assertions enabled we do track the owner.
+#if defined(DEBUG)
+  ASSERT(owner_ == Isolate::Current());
+  owner_ = NULL;
+#endif  // defined(DEBUG)
 }
 
 
 Mutex::~Mutex() {
   int result = pthread_mutex_destroy(data_.mutex());
   // Verify that the pthread_mutex was destroyed.
   VALIDATE_PTHREAD_RESULT(result);
+
+  // When running with assertions enabled we do track the owner.
+#if defined(DEBUG)
+  ASSERT(owner_ == NULL);
+#endif  // defined(DEBUG)
 }
 
 
 void Mutex::Lock() {
   int result = pthread_mutex_lock(data_.mutex());
   // Specifically check for dead lock to help debugging.
   ASSERT(result != EDEADLK);
   ASSERT(result == 0);  // Verify no other errors.
-  // TODO(iposva): Do we need to track lock owners?
+  // When running with assertions enabled we do track the owner.
+#if defined(DEBUG)
+  owner_ = Isolate::Current();
+#endif  // defined(DEBUG)
 }
 
 
 bool Mutex::TryLock() {
   int result = pthread_mutex_trylock(data_.mutex());
   // Return false if the lock is busy and locking failed.
   if (result == EBUSY) {
     return false;
   }
   ASSERT(result == 0);  // Verify no other errors.
-  // TODO(iposva): Do we need to track lock owners?
+  // When running with assertions enabled we do track the owner.
+#if defined(DEBUG)
+  owner_ = Isolate::Current();
+#endif  // defined(DEBUG)
   return true;
 }
 
 
 void Mutex::Unlock() {
-  // TODO(iposva): Do we need to track lock owners?
+  // When running with assertions enabled we do track the owner.
+#if defined(DEBUG)
+  ASSERT(owner_ == Isolate::Current());
+  owner_ = NULL;
+#endif  // defined(DEBUG)
   int result = pthread_mutex_unlock(data_.mutex());
   // Specifically check for wrong thread unlocking to aid debugging.
   ASSERT(result != EPERM);
   ASSERT(result == 0);  // Verify no other errors.
 }
 
 
 Monitor::Monitor() {
   pthread_mutexattr_t mutex_attr;
   int result = pthread_mutexattr_init(&mutex_attr);
@@ skipping 79 matching lines @@
 
 void Monitor::NotifyAll() {
   // TODO(iposva): Do we need to track lock owners?
   int result = pthread_cond_broadcast(data_.cond());
   VALIDATE_PTHREAD_RESULT(result);
 }
 
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)