Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 474883003: Move focus from the view manager to the window manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 3b5d9579c8a3fe1fc0adf0d342ccb3fef6192d59..411f8cc7c107f09227dfdfb2559674e89fed20c8 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -105,9 +105,6 @@ interface ViewManagerService {
handle<shared_buffer> buffer,
uint32 buffer_size) => (bool success);
- // Sets focus to the specified view.
- SetFocus(uint32 view_id) => (bool success);
-
// Embeds the app for |url| in the specified view. More specifically this
// creates a new connection to the specified url, expecting to get a
// ViewManagerClient and configures it with the root view |view|. Fails
@@ -184,15 +181,6 @@ interface ViewManagerClient {
// Invoked when an event is targeted at the specified view.
OnViewInputEvent(uint32 view, mojo.Event event) => ();
- // Invoked when focus shifts from one View to another. |gained_focus_id| is
- // the id of the view that gained focus, or 0 if the view that gained focus is
- // not known to this connection. |lost_focus_id| is likewise the view that
- // lost focus.
- // TODO(beng): once aura is removed from the service, focus management should
- // entirely move to the window manager and this method can be
- // removed.
- OnFocusChanged(uint32 gained_focus_id, uint32 lost_focus_id);
-
// TODO(sky): The following methods represent an interface between the view
// manager and the application embedded at the service root view
// (i.e. the window manager). These methods are not called on
@@ -202,8 +190,8 @@ interface ViewManagerClient {
// Requests the window manager create a "top level" view embedding |url|.
Embed(string url, ServiceProvider& service_provider);
- // Requests the view manager dispatch the event targeted at |view|.
- DispatchOnViewInputEvent(uint32 view, mojo.Event event);
+ // Requests the view manager dispatch the event.
+ DispatchOnViewInputEvent(mojo.Event event);
};
}
« no previous file with comments | « mojo/services/public/cpp/view_manager/window_manager_delegate.h ('k') | mojo/services/view_manager/access_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698