Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: mojo/services/view_manager/root_view_manager.cc

Issue 474883003: Move focus from the view manager to the window manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/view_manager/root_view_manager.h" 5 #include "mojo/services/view_manager/root_view_manager.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/scoped_observer.h" 8 #include "base/scoped_observer.h"
9 #include "mojo/public/cpp/application/application_connection.h" 9 #include "mojo/public/cpp/application/application_connection.h"
10 #include "mojo/services/view_manager/root_node_manager.h" 10 #include "mojo/services/view_manager/root_node_manager.h"
11 #include "mojo/services/view_manager/root_view_manager_delegate.h" 11 #include "mojo/services/view_manager/root_view_manager_delegate.h"
12 #include "mojo/services/view_manager/screen_impl.h" 12 #include "mojo/services/view_manager/screen_impl.h"
13 #include "mojo/services/view_manager/window_tree_host_impl.h" 13 #include "mojo/services/view_manager/window_tree_host_impl.h"
14 #include "ui/aura/client/default_capture_client.h" 14 #include "ui/aura/client/default_capture_client.h"
15 #include "ui/aura/client/focus_change_observer.h"
16 #include "ui/aura/client/focus_client.h" 15 #include "ui/aura/client/focus_client.h"
17 #include "ui/aura/client/window_tree_client.h" 16 #include "ui/aura/client/window_tree_client.h"
18 #include "ui/aura/window.h" 17 #include "ui/aura/window.h"
19 #include "ui/aura/window_observer.h" 18 #include "ui/aura/window_observer.h"
20 19
21 namespace mojo { 20 namespace mojo {
22 namespace service { 21 namespace service {
23 22
24 // TODO(sky): revisit this, we may need a more sophisticated FocusClient 23 // TODO(sky): Remove once aura is removed from the service.
25 // implementation. 24 class FocusClientImpl : public aura::client::FocusClient {
26 class FocusClientImpl : public aura::client::FocusClient,
27 public aura::WindowObserver {
28 public: 25 public:
29 FocusClientImpl() 26 FocusClientImpl() {}
30 : focused_window_(NULL),
31 observer_manager_(this) {
32 }
33 virtual ~FocusClientImpl() {} 27 virtual ~FocusClientImpl() {}
34 28
35 private: 29 private:
36 // Overridden from aura::client::FocusClient: 30 // Overridden from aura::client::FocusClient:
37 virtual void AddObserver(aura::client::FocusChangeObserver* observer) 31 virtual void AddObserver(
38 OVERRIDE { 32 aura::client::FocusChangeObserver* observer) OVERRIDE {}
39 observers_.AddObserver(observer); 33 virtual void RemoveObserver(
40 } 34 aura::client::FocusChangeObserver* observer) OVERRIDE {}
41 virtual void RemoveObserver(aura::client::FocusChangeObserver* observer) 35 virtual void FocusWindow(aura::Window* window) OVERRIDE {}
42 OVERRIDE { 36 virtual void ResetFocusWithinActiveWindow(aura::Window* window) OVERRIDE {}
43 observers_.RemoveObserver(observer); 37 virtual aura::Window* GetFocusedWindow() OVERRIDE { return NULL; }
44 }
45 virtual void FocusWindow(aura::Window* window) OVERRIDE {
46 if (window && !window->CanFocus())
47 return;
48 if (window == focused_window_)
49 return;
50 if (focused_window_)
51 observer_manager_.Remove(focused_window_);
52 aura::Window* old_focused_window = focused_window_;
53 focused_window_ = window;
54 if (focused_window_)
55 observer_manager_.Add(focused_window_);
56
57 FOR_EACH_OBSERVER(aura::client::FocusChangeObserver,
58 observers_,
59 OnWindowFocused(focused_window_, old_focused_window));
60 aura::client::FocusChangeObserver* observer =
61 aura::client::GetFocusChangeObserver(old_focused_window);
62 if (observer)
63 observer->OnWindowFocused(focused_window_, old_focused_window);
64 observer = aura::client::GetFocusChangeObserver(focused_window_);
65 if (observer)
66 observer->OnWindowFocused(focused_window_, old_focused_window);
67 }
68 virtual void ResetFocusWithinActiveWindow(aura::Window* window) OVERRIDE {
69 if (!window->Contains(focused_window_))
70 FocusWindow(window);
71 }
72 virtual aura::Window* GetFocusedWindow() OVERRIDE {
73 return focused_window_;
74 }
75
76 // Overridden from WindowObserver:
77 virtual void OnWindowDestroying(aura::Window* window) OVERRIDE {
78 DCHECK_EQ(window, focused_window_);
79 FocusWindow(NULL);
80 }
81
82 aura::Window* focused_window_;
83 ScopedObserver<aura::Window, aura::WindowObserver> observer_manager_;
84 ObserverList<aura::client::FocusChangeObserver> observers_;
85 38
86 DISALLOW_COPY_AND_ASSIGN(FocusClientImpl); 39 DISALLOW_COPY_AND_ASSIGN(FocusClientImpl);
87 }; 40 };
88 41
89 class WindowTreeClientImpl : public aura::client::WindowTreeClient { 42 class WindowTreeClientImpl : public aura::client::WindowTreeClient {
90 public: 43 public:
91 explicit WindowTreeClientImpl(aura::Window* window) : window_(window) { 44 explicit WindowTreeClientImpl(aura::Window* window) : window_(window) {
92 aura::client::SetWindowTreeClient(window_, this); 45 aura::client::SetWindowTreeClient(window_, this);
93 } 46 }
94 47
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 screen_.reset(ScreenImpl::Create()); 79 screen_.reset(ScreenImpl::Create());
127 gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE, screen_.get()); 80 gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE, screen_.get());
128 NativeViewportPtr viewport; 81 NativeViewportPtr viewport;
129 app_connection->ConnectToService( 82 app_connection->ConnectToService(
130 "mojo:mojo_native_viewport_service", &viewport); 83 "mojo:mojo_native_viewport_service", &viewport);
131 window_tree_host_.reset(new WindowTreeHostImpl( 84 window_tree_host_.reset(new WindowTreeHostImpl(
132 viewport.Pass(), 85 viewport.Pass(),
133 gfx::Rect(800, 600), 86 gfx::Rect(800, 600),
134 base::Bind(&RootViewManager::OnCompositorCreated, 87 base::Bind(&RootViewManager::OnCompositorCreated,
135 base::Unretained(this)), 88 base::Unretained(this)),
136 native_viewport_closed_callback)); 89 native_viewport_closed_callback,
90 base::Bind(&RootNodeManager::DispatchNodeInputEventToWindowManager,
91 base::Unretained(root_node_manager_))));
137 } 92 }
138 93
139 RootViewManager::~RootViewManager() { 94 RootViewManager::~RootViewManager() {
140 window_tree_client_.reset(); 95 window_tree_client_.reset();
141 window_tree_host_.reset(); 96 window_tree_host_.reset();
142 gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE, NULL); 97 gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE, NULL);
143 } 98 }
144 99
145 void RootViewManager::OnCompositorCreated() { 100 void RootViewManager::OnCompositorCreated() {
146 base::AutoReset<bool> resetter(&in_setup_, true); 101 base::AutoReset<bool> resetter(&in_setup_, true);
147 window_tree_host_->InitHost(); 102 window_tree_host_->InitHost();
148 103
149 aura::Window* root = root_node_manager_->root()->window(); 104 aura::Window* root = root_node_manager_->root()->window();
150 window_tree_host_->window()->AddChild(root); 105 window_tree_host_->window()->AddChild(root);
151 root->SetBounds(gfx::Rect(window_tree_host_->window()->bounds().size())); 106 root->SetBounds(gfx::Rect(window_tree_host_->window()->bounds().size()));
152 root_node_manager_->root()->window()->Show(); 107 root_node_manager_->root()->window()->Show();
153 108
154 window_tree_client_.reset( 109 window_tree_client_.reset(
155 new WindowTreeClientImpl(window_tree_host_->window())); 110 new WindowTreeClientImpl(window_tree_host_->window()));
156 111
157 focus_client_.reset(new FocusClientImpl()); 112 focus_client_.reset(new FocusClientImpl);
158 aura::client::SetFocusClient(window_tree_host_->window(), 113 aura::client::SetFocusClient(window_tree_host_->window(),
159 focus_client_.get()); 114 focus_client_.get());
160 focus_client_->AddObserver(root_node_manager_);
161 115
162 window_tree_host_->Show(); 116 window_tree_host_->Show();
163 117
164 delegate_->OnRootViewManagerWindowTreeHostCreated(); 118 delegate_->OnRootViewManagerWindowTreeHostCreated();
165 } 119 }
166 120
167 } // namespace service 121 } // namespace service
168 } // namespace mojo 122 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/view_manager/root_node_manager.cc ('k') | mojo/services/view_manager/view_manager_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698