Clean parsing for -webkit-transform-origin*

Clean parsing for -webkit-transform-origin*

The indirection of parseWebkitTransformOrigin only adds complexity.

BUG=404023
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180323

[alancutter (OOO until 2018), 2014-08-15 01:00:04]

lgtm with nit.

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:3141: return false;
This can be merged into the if block below.

[Timothy Loh, 2014-08-15 01:03:18]

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:3141: return false;
On 2014/08/15 01:00:03, alancutter wrote:
> This can be merged into the if block below.

Not sure what you mean here, the "if (m_valueList->current())" branch below
happens after we've already added properties. Not adding properties at all seems
like a better pattern than adding then rolling back.

[Timothy Loh, 2014-08-15 01:11:42]

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:3141: return false;
On 2014/08/15 01:03:18, Timothy Loh wrote:
> On 2014/08/15 01:00:03, alancutter wrote:
> > This can be merged into the if block below.
> 
> Not sure what you mean here, the "if (m_valueList->current())" branch below
> happens after we've already added properties. Not adding properties at all
seems
> like a better pattern than adding then rolling back.

err yeah I can move adding properties lower, will do that :|

[Timothy Loh, 2014-08-15 01:26:36]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2014-08-15 01:26:41]

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/474873002/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:3141: return false;
On 2014/08/15 01:11:41, Timothy Loh wrote:
> On 2014/08/15 01:03:18, Timothy Loh wrote:
> > On 2014/08/15 01:00:03, alancutter wrote:
> > > This can be merged into the if block below.
> > 
> > Not sure what you mean here, the "if (m_valueList->current())" branch below
> > happens after we've already added properties. Not adding properties at all
> seems
> > like a better pattern than adding then rolling back.
> 
> err yeah I can move adding properties lower, will do that :|

Done.

[commit-bot: I haz the power, 2014-08-15 01:28:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/timloh@chromium.org/474873002/20001

[commit-bot: I haz the power, 2014-08-15 02:35:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22862)

[commit-bot: I haz the power, 2014-08-15 03:17:29]

Committed patchset #2 (20001) as 180323