Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 474843002: Include builder_name in full_results in telemetry_unittests. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
tonyg, ojan
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Include builder_name in full_results in telemetry_unittests. Turns out we need it to be included in full_results.json as well as passed as a URL parameter :(. TBR=ojan@chromium.org, tonyg@chromium.org BUG=323212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Committed patchset #1 manually as 289459 (presubmit successful).
6 years, 4 months ago (2014-08-14 04:05:27 UTC) #1
ojan
Incidentally, down the road we should include all the things in the json, e.g. step ...
6 years, 4 months ago (2014-08-14 04:11:57 UTC) #2
Dirk Pranke
On 2014/08/14 04:11:57, ojan-only-code-yellow-reviews wrote: > Incidentally, down the road we should include all the ...
6 years, 4 months ago (2014-08-14 04:14:52 UTC) #3
ojan
6 years, 4 months ago (2014-08-14 04:29:19 UTC) #4
Message was sent while issue was closed.
On 2014/08/14 at 04:14:52, dpranke wrote:
> On 2014/08/14 04:11:57, ojan-only-code-yellow-reviews wrote:
> > Incidentally, down the road we should include all the things in the json,
e.g.
> > step name, master url, etc. Sometimes when reading these files out you want
to
> > know these things, but don't have the query parameters.
> 
> Oh, hey, I actually had this one documented as being needed, and missed it
anyway :(.
> 
> I think the only two other fields that are URL parameters but aren't included
are the step name / test type and the master name. It's certainly easy enough to
include them.
> 
> We could also add things like platform, configuration, etc., if you didn't
want to have to derive that from the builder name.

Yup. I want all these things. It's really silly that we try to derive that from
the builder name, especially since the builder name sometimes doesn't have all
that information.

Powered by Google App Engine
This is Rietveld 408576698