Issue 474813002: rebaseline_server: include setA/setB descriptions in output JSON

Issue 474813002: rebaseline_server: include setA/setB descriptions in output JSON (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years ago

Reviewers:
rmistry

CC:
reviews_skia.org, stephana

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

rebaseline_server: include setA/setB descriptions in output JSON This is needed for rebaselining using the shared rebaseline_server instance: by telling the client which git revision was used to fetch expectations, we allow the client to pass that back along with new baselines (so the server knows which revision to patch). This is also handy in that it allows the server to tell the client more about the different result sets (which files they were generated from). BUG=skia:1918 NOTRY=true Committed: https://skia.googlesource.com/skia/+/5c4b137592a7937b4d02d72a976fa783f8d3675a

Patch Set 1 : add setA/setB descriptions to rebaseline_server output JSON, and use them to indicate gs:// source dirs #

Patch Set 2 : update schemaVersion in unittest result expectations #

Patch Set 3 : if either set is of "repo:" type, include repo_revision #

Total comments: 2

Patch Set 4 : use posixpath.join() #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -21 lines)			Patch
M	gm/gm_json.py	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/compare_configs.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gm/rebaseline_server/compare_rendered_pictures.py	View	1 2	5 chunks	+53 lines, -5 lines	0 comments	Download
M	gm/rebaseline_server/compare_rendered_pictures_test.py	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	gm/rebaseline_server/compare_to_expectations.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gm/rebaseline_server/results.py	View	1 2	6 chunks	+17 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/server.py	View	1 2 3	4 chunks	+8 lines, -4 lines	0 comments	Download
M	gm/rebaseline_server/static/constants.js	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/static/live-view.html	View	1 2	3 chunks	+10 lines, -4 lines	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json	View	1 2	1 chunk	+15 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json	View	1 2	1 chunk	+15 lines, -1 line	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

Ravi (and Stephan): PTAL at patchset 3. In this case, I advise just reviewing the ...

6 years, 4 months ago (2014-08-14 05:11:14 UTC) #1

rmistry

LGTM https://codereview.chromium.org/474813002/diff/40001/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/474813002/diff/40001/gm/rebaseline_server/server.py#newcode120 gm/rebaseline_server/server.py:120: compare_rendered_pictures.REPO_URL_PREFIX + 'expectations/skp') Use posixpath.join instead?

6 years, 4 months ago (2014-08-14 12:44:56 UTC) #2

epoger

https://codereview.chromium.org/474813002/diff/40001/gm/rebaseline_server/server.py File gm/rebaseline_server/server.py (right): https://codereview.chromium.org/474813002/diff/40001/gm/rebaseline_server/server.py#newcode120 gm/rebaseline_server/server.py:120: compare_rendered_pictures.REPO_URL_PREFIX + 'expectations/skp') On 2014/08/14 12:44:56, rmistry wrote: > ...

6 years, 4 months ago (2014-08-14 14:12:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/474813002/60001

6 years, 4 months ago (2014-08-14 14:12:35 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 14:12:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (60001) as 5c4b137592a7937b4d02d72a976fa783f8d3675a

Expand Messages | Collapse Messages