Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 474793002: Add GraphicsLayerDebugInfo::includesNewPaintInvalidation to distinguish paint from new RenderObjects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: use GraphicsLayerInfo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 bool isTablePart() const { return isTableCell() || isRenderTableCol() || isT ableCaption() || isTableRow() || isTableSection(); } 424 bool isTablePart() const { return isTableCell() || isRenderTableCol() || isT ableCaption() || isTableRow() || isTableSection(); }
425 425
426 inline bool isBeforeContent() const; 426 inline bool isBeforeContent() const;
427 inline bool isAfterContent() const; 427 inline bool isAfterContent() const;
428 inline bool isBeforeOrAfterContent() const; 428 inline bool isBeforeOrAfterContent() const;
429 static inline bool isAfterContent(const RenderObject* obj) { return obj && o bj->isAfterContent(); } 429 static inline bool isAfterContent(const RenderObject* obj) { return obj && o bj->isAfterContent(); }
430 430
431 bool hasCounterNodeMap() const { return m_bitfields.hasCounterNodeMap(); } 431 bool hasCounterNodeMap() const { return m_bitfields.hasCounterNodeMap(); }
432 void setHasCounterNodeMap(bool hasCounterNodeMap) { m_bitfields.setHasCounte rNodeMap(hasCounterNodeMap); } 432 void setHasCounterNodeMap(bool hasCounterNodeMap) { m_bitfields.setHasCounte rNodeMap(hasCounterNodeMap); }
433 bool everHadLayout() const { return m_bitfields.everHadLayout(); } 433 bool everHadLayout() const { return m_bitfields.everHadLayout(); }
434 bool everHadPaintInvalidation() const { return m_bitfields.everHadPaintInval idation(); }
434 435
435 bool childrenInline() const { return m_bitfields.childrenInline(); } 436 bool childrenInline() const { return m_bitfields.childrenInline(); }
436 void setChildrenInline(bool b) { m_bitfields.setChildrenInline(b); } 437 void setChildrenInline(bool b) { m_bitfields.setChildrenInline(b); }
437 bool hasColumns() const { return m_bitfields.hasColumns(); } 438 bool hasColumns() const { return m_bitfields.hasColumns(); }
438 void setHasColumns(bool b = true) { m_bitfields.setHasColumns(b); } 439 void setHasColumns(bool b = true) { m_bitfields.setHasColumns(b); }
439 440
440 bool alwaysCreateLineBoxesForRenderInline() const 441 bool alwaysCreateLineBoxesForRenderInline() const
441 { 442 {
442 ASSERT(isRenderInline()); 443 ASSERT(isRenderInline());
443 return m_bitfields.alwaysCreateLineBoxesForRenderInline(); 444 return m_bitfields.alwaysCreateLineBoxesForRenderInline();
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
1305 1306
1306 ADD_BOOLEAN_BITFIELD(hasPendingResourceUpdate, HasPendingResourceUpdate) ; 1307 ADD_BOOLEAN_BITFIELD(hasPendingResourceUpdate, HasPendingResourceUpdate) ;
1307 1308
1308 // from RenderBlock 1309 // from RenderBlock
1309 ADD_BOOLEAN_BITFIELD(childrenInline, ChildrenInline); 1310 ADD_BOOLEAN_BITFIELD(childrenInline, ChildrenInline);
1310 ADD_BOOLEAN_BITFIELD(hasColumns, HasColumns); 1311 ADD_BOOLEAN_BITFIELD(hasColumns, HasColumns);
1311 1312
1312 // from RenderInline 1313 // from RenderInline
1313 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline); 1314 ADD_BOOLEAN_BITFIELD(alwaysCreateLineBoxesForRenderInline, AlwaysCreateL ineBoxesForRenderInline);
1314 1315
1316 ADD_BOOLEAN_BITFIELD(everHadPaintInvalidation, EverHadPaintInvalidation) ;
1317
1315 private: 1318 private:
1316 unsigned m_positionedState : 2; // PositionedState 1319 unsigned m_positionedState : 2; // PositionedState
1317 unsigned m_selectionState : 3; // SelectionState 1320 unsigned m_selectionState : 3; // SelectionState
1318 unsigned m_flowThreadState : 2; // FlowThreadState 1321 unsigned m_flowThreadState : 2; // FlowThreadState
1319 unsigned m_boxDecorationBackgroundState : 2; // BoxDecorationBackgroundS tate 1322 unsigned m_boxDecorationBackgroundState : 2; // BoxDecorationBackgroundS tate
1320 1323
1321 public: 1324 public:
1322 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; } 1325 bool isOutOfFlowPositioned() const { return m_positionedState == IsOutOf FlowPositioned; }
1323 bool isRelPositioned() const { return m_positionedState == IsRelativelyP ositioned; } 1326 bool isRelPositioned() const { return m_positionedState == IsRelativelyP ositioned; }
1324 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; } 1327 bool isPositioned() const { return m_positionedState != IsStaticallyPosi tioned; }
(...skipping 19 matching lines...) Expand all
1344 1347
1345 RenderObjectBitfields m_bitfields; 1348 RenderObjectBitfields m_bitfields;
1346 1349
1347 void setSelfNeedsLayout(bool b) { m_bitfields.setSelfNeedsLayout(b); } 1350 void setSelfNeedsLayout(bool b) { m_bitfields.setSelfNeedsLayout(b); }
1348 void setNeedsPositionedMovementLayout(bool b) { m_bitfields.setNeedsPosition edMovementLayout(b); } 1351 void setNeedsPositionedMovementLayout(bool b) { m_bitfields.setNeedsPosition edMovementLayout(b); }
1349 void setNormalChildNeedsLayout(bool b) { m_bitfields.setNormalChildNeedsLayo ut(b); } 1352 void setNormalChildNeedsLayout(bool b) { m_bitfields.setNormalChildNeedsLayo ut(b); }
1350 void setPosChildNeedsLayout(bool b) { m_bitfields.setPosChildNeedsLayout(b); } 1353 void setPosChildNeedsLayout(bool b) { m_bitfields.setPosChildNeedsLayout(b); }
1351 void setNeedsSimplifiedNormalFlowLayout(bool b) { m_bitfields.setNeedsSimpli fiedNormalFlowLayout(b); } 1354 void setNeedsSimplifiedNormalFlowLayout(bool b) { m_bitfields.setNeedsSimpli fiedNormalFlowLayout(b); }
1352 void setIsDragging(bool b) { m_bitfields.setIsDragging(b); } 1355 void setIsDragging(bool b) { m_bitfields.setIsDragging(b); }
1353 void setEverHadLayout(bool b) { m_bitfields.setEverHadLayout(b); } 1356 void setEverHadLayout(bool b) { m_bitfields.setEverHadLayout(b); }
1357 void setEverHadPaintInvalidation(bool b) { m_bitfields.setEverHadPaintInvali dation(b); }
chrishtr 2014/08/20 17:10:31 It's only ever set to true. Rename to setHadPaintI
kouhei (in TOK) 2014/08/21 04:42:53 Done.
1354 void setShouldInvalidateOverflowForPaint(bool b) { m_bitfields.setShouldInva lidateOverflowForPaint(b); } 1358 void setShouldInvalidateOverflowForPaint(bool b) { m_bitfields.setShouldInva lidateOverflowForPaint(b); }
1355 void setSelfNeedsOverflowRecalcAfterStyleChange(bool b) { m_bitfields.setSel fNeedsOverflowRecalcAfterStyleChange(b); } 1359 void setSelfNeedsOverflowRecalcAfterStyleChange(bool b) { m_bitfields.setSel fNeedsOverflowRecalcAfterStyleChange(b); }
1356 void setChildNeedsOverflowRecalcAfterStyleChange(bool b) { m_bitfields.setCh ildNeedsOverflowRecalcAfterStyleChange(b); } 1360 void setChildNeedsOverflowRecalcAfterStyleChange(bool b) { m_bitfields.setCh ildNeedsOverflowRecalcAfterStyleChange(b); }
1357 1361
1358 private: 1362 private:
1359 // Store state between styleWillChange and styleDidChange 1363 // Store state between styleWillChange and styleDidChange
1360 static bool s_affectsParentBlock; 1364 static bool s_affectsParentBlock;
1361 1365
1362 // This stores the paint invalidation rect from the previous layout. 1366 // This stores the paint invalidation rect from the previous layout.
1363 LayoutRect m_previousPaintInvalidationRect; 1367 LayoutRect m_previousPaintInvalidationRect;
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 void showTree(const blink::RenderObject*); 1575 void showTree(const blink::RenderObject*);
1572 void showLineTree(const blink::RenderObject*); 1576 void showLineTree(const blink::RenderObject*);
1573 void showRenderTree(const blink::RenderObject* object1); 1577 void showRenderTree(const blink::RenderObject* object1);
1574 // We don't make object2 an optional parameter so that showRenderTree 1578 // We don't make object2 an optional parameter so that showRenderTree
1575 // can be called from gdb easily. 1579 // can be called from gdb easily.
1576 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2); 1580 void showRenderTree(const blink::RenderObject* object1, const blink::RenderObjec t* object2);
1577 1581
1578 #endif 1582 #endif
1579 1583
1580 #endif // RenderObject_h 1584 #endif // RenderObject_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698