Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 474793002: Add GraphicsLayerDebugInfo::includesNewPaintInvalidation to distinguish paint from new RenderObjects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: use GraphicsLayerInfo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1654 matching lines...) Expand 10 before | Expand all | Expand 10 after
1665 InvalidationReason invalidationReason = getPaintInvalidationReason(paintInva lidationContainer, oldBounds, oldLocation, newBounds, newLocation); 1665 InvalidationReason invalidationReason = getPaintInvalidationReason(paintInva lidationContainer, oldBounds, oldLocation, newBounds, newLocation);
1666 1666
1667 if (invalidationReason == InvalidationNone) 1667 if (invalidationReason == InvalidationNone)
1668 return invalidationReason; 1668 return invalidationReason;
1669 1669
1670 if (invalidationReason == InvalidationIncremental) { 1670 if (invalidationReason == InvalidationIncremental) {
1671 incrementallyInvalidatePaint(paintInvalidationContainer, oldBounds, newB ounds, newLocation); 1671 incrementallyInvalidatePaint(paintInvalidationContainer, oldBounds, newB ounds, newLocation);
1672 return invalidationReason; 1672 return invalidationReason;
1673 } 1673 }
1674 1674
1675 if (view()->usesCompositing() && !everHadPaintInvalidation())
1676 paintInvalidationContainer.layer()->paintInvalidator().setBackingInclude sFirstPaintInvalidation();
1677 setEverHadPaintInvalidation(true);
chrishtr 2014/08/20 17:10:31 I think this should go in RenderObject::invalidate
kouhei (in TOK) 2014/08/21 04:42:53 Hmm. RenderObject::invalidatePaintUsingContainer()
chrishtr 2014/08/21 21:28:34 Well we need to make sure it's hit in all cases. S
kouhei (in TOK) 2014/08/25 01:57:58 Done.
1678
1675 fullyInvalidatePaint(paintInvalidationContainer, invalidationReason, oldBoun ds, newBounds); 1679 fullyInvalidatePaint(paintInvalidationContainer, invalidationReason, oldBoun ds, newBounds);
1676 return invalidationReason; 1680 return invalidationReason;
1677 } 1681 }
1678 1682
1679 InvalidationReason RenderObject::getPaintInvalidationReason(const RenderLayerMod elObject& paintInvalidationContainer, 1683 InvalidationReason RenderObject::getPaintInvalidationReason(const RenderLayerMod elObject& paintInvalidationContainer,
1680 const LayoutRect& oldBounds, const LayoutPoint& oldLocation, const LayoutRec t& newBounds, const LayoutPoint& newLocation) 1684 const LayoutRect& oldBounds, const LayoutPoint& oldLocation, const LayoutRec t& newBounds, const LayoutPoint& newLocation)
1681 { 1685 {
1682 if (shouldDoFullPaintInvalidation()) 1686 if (shouldDoFullPaintInvalidation())
1683 return InvalidationFull; 1687 return InvalidationFull;
1684 1688
(...skipping 1789 matching lines...) Expand 10 before | Expand all | Expand 10 after
3474 { 3478 {
3475 if (object1) { 3479 if (object1) {
3476 const blink::RenderObject* root = object1; 3480 const blink::RenderObject* root = object1;
3477 while (root->parent()) 3481 while (root->parent())
3478 root = root->parent(); 3482 root = root->parent();
3479 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3483 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3480 } 3484 }
3481 } 3485 }
3482 3486
3483 #endif 3487 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698