Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 474723002: Enable remote CoreAnimation API by default. (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_flag
Project:
chromium
Visibility:
Public.

Description

Enable remote CoreAnimation API by default. BUG=312462 Committed: https://crrev.com/21d3def097c21dee98b2b1d038cd5a78c023b022 Cr-Commit-Position: refs/heads/master@{#299213}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Patch Set 3 : Resolve #

Patch Set 4 : Add OS version check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/remote_layer_api.mm View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (1 generated)
ccameron
This is part 2 of 2 (this doesn't get enabled until after the branch).
6 years, 4 months ago (2014-08-14 00:01:19 UTC) #1
sky
https://codereview.chromium.org/474723002/diff/1/ui/base/cocoa/remote_layer_api.mm File ui/base/cocoa/remote_layer_api.mm (right): https://codereview.chromium.org/474723002/diff/1/ui/base/cocoa/remote_layer_api.mm#newcode15 ui/base/cocoa/remote_layer_api.mm:15: static bool disabled_at_command_line = Same comment about static here.
6 years, 4 months ago (2014-08-14 00:19:34 UTC) #2
ccameron
Thanks! https://codereview.chromium.org/474723002/diff/1/ui/base/cocoa/remote_layer_api.mm File ui/base/cocoa/remote_layer_api.mm (right): https://codereview.chromium.org/474723002/diff/1/ui/base/cocoa/remote_layer_api.mm#newcode15 ui/base/cocoa/remote_layer_api.mm:15: static bool disabled_at_command_line = On 2014/08/14 00:19:34, sky ...
6 years, 4 months ago (2014-08-14 00:33:55 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-08-14 16:41:51 UTC) #4
Ken Russell (switch to Gerrit)
LGTM too.
6 years, 4 months ago (2014-08-15 20:24:37 UTC) #5
ccameron
This was causing poor performance when switching GPUs. When using IOSurfaces, I found that I ...
6 years, 2 months ago (2014-10-10 18:29:01 UTC) #6
ccameron
On 2014/10/10 18:29:01, ccameron1 wrote: > This was causing poor performance when switching GPUs. > ...
6 years, 2 months ago (2014-10-10 18:33:24 UTC) #7
ccameron
Turning this on (like 2 months after I thought I would).
6 years, 2 months ago (2014-10-10 23:14:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/474723002/270001
6 years, 2 months ago (2014-10-10 23:15:08 UTC) #10
Ken Russell (switch to Gerrit)
LGTM if this has been tested. Please watch the Mac bots after this lands (in ...
6 years, 2 months ago (2014-10-10 23:18:16 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:270001)
6 years, 2 months ago (2014-10-10 23:46:08 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/21d3def097c21dee98b2b1d038cd5a78c023b022 Cr-Commit-Position: refs/heads/master@{#299213}
6 years, 2 months ago (2014-10-10 23:47:39 UTC) #13
ccameron
6 years, 2 months ago (2014-10-11 01:00:12 UTC) #14
Message was sent while issue was closed.
Mac GPU bots have gotten past this ok. Feeling lucky!!

Powered by Google App Engine
This is Rietveld 408576698