Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 474693002: Changes to media.gyp for Chromoting iOS client (Closed)

Created:
6 years, 4 months ago by dcaiafa
Modified:
6 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changes to media.gyp for Chromoting iOS client This makes the following changes to media.gyp to make it compile for iOS (for the Chromoting iOS client): - Don't use ffmpeg or libvpx in media (just like Android) - Do use libyuv - Add yasm flag to decorate functions correctly for iOS (just like in the Mac) BUG=134226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289973

Patch Set 1 #

Patch Set 2 : Update gn as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M media/BUILD.gn View 1 2 chunks +1 line, -4 lines 0 comments Download
M media/base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 4 chunks +5 lines, -10 lines 0 comments Download
M media/media_options.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dcaiafa
PTAL
6 years, 4 months ago (2014-08-14 00:15:09 UTC) #1
DaleCurtis
lgtm
6 years, 4 months ago (2014-08-14 00:25:31 UTC) #2
dcaiafa
The CQ bit was checked by dcaiafa@chromium.org
6 years, 4 months ago (2014-08-14 16:25:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/474693002/20001
6 years, 4 months ago (2014-08-14 16:28:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 00:49:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 06:50:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/6057)
6 years, 4 months ago (2014-08-15 06:50:05 UTC) #7
dcaiafa
The CQ bit was checked by dcaiafa@chromium.org
6 years, 4 months ago (2014-08-15 18:03:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcaiafa@chromium.org/474693002/20001
6 years, 4 months ago (2014-08-15 18:06:05 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 19:25:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289973

Powered by Google App Engine
This is Rietveld 408576698