Issue 474683002: Use scrollContentsSlowPath when scrolling with background-attachment: fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474683002: Use scrollContentsSlowPath when scrolling with background-attachment: fixed (Closed)

Created:
6 years, 4 months ago by abarth-chromium

Modified:
6 years, 4 months ago

Reviewers:
Ian Vollick

CC:
blink-reviews, trchen

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use scrollContentsSlowPath when scrolling with background-attachment: fixed This CL causes us to bail out of the fast scrolling path if we have slow repainting objects (i.e., background-attachment: fixed). We've done this for a long time, by my recent CL removed this behavior and we appear to lack test coverage for it. R=vollick@chromium.org BUG=402747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180223

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -4 lines)			Patch
A	LayoutTests/fast/repaint/full-viewport-repaint-for-background-attachment-fixed.html	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/repaint/full-viewport-repaint-for-background-attachment-fixed-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/474683002/1

6 years, 4 months ago (2014-08-14 00:32:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180223

Expand Messages | Collapse Messages