Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 474653002: Android power telemetry: Update dumpsys power monitor parser to accept version 9. (Closed)

Created:
6 years, 4 months ago by tommycli
Modified:
6 years, 4 months ago
Reviewers:
tonyg, qsr
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Android power telemetry: Update dumpsys power monitor parser to accept version 9. On my L-release flash, dumpsys has version number 9 now. However, it still seems to work with the dumpsys power monitor parser, so I think we should allow it to accept 9 also. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tommycli
tonyg: PTAL, thanks!
6 years, 4 months ago (2014-08-13 22:27:31 UTC) #1
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-13 22:28:50 UTC) #2
tonyg
lgtm
6 years, 4 months ago (2014-08-13 22:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/474653002/1
6 years, 4 months ago (2014-08-13 22:32:35 UTC) #4
tommycli
tonyg: How good are the dumpsys power measurements? Are they suitable for doing perf bots ...
6 years, 4 months ago (2014-08-14 01:02:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 289606
6 years, 4 months ago (2014-08-14 16:02:26 UTC) #6
tonyg
On 2014/08/14 01:02:52, tommycli wrote: > tonyg: How good are the dumpsys power measurements? Are ...
6 years, 4 months ago (2014-08-20 18:23:11 UTC) #7
tommycli
6 years, 4 months ago (2014-08-21 18:22:40 UTC) #8
Message was sent while issue was closed.
On 2014/08/20 18:23:11, tonyg wrote:
> On 2014/08/14 01:02:52, tommycli wrote:
> > tonyg: How good are the dumpsys power measurements? Are they suitable for
> doing
> > perf bots for android? or should the perf bots use monsoons?
> 
> They're different techniques. The dumpsys monitor gives you some signals that
> correlate the CPU energy consumption. But it doesn't give you actual energy
> consumption. The monsoon measures that physically. I think we'll eventually
need
> bots with both.

tonyg: I would be interested in starting with getting some some dumpsys Android
power bots running. Any pointers on where to get started?

Powered by Google App Engine
This is Rietveld 408576698