Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/component_updater/component_updater_utils.cc

Issue 474633005: Componentize component_updater: Split crx_file code off into its own component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove shared library export Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/component_unpacker.cc ('k') | chrome/browser/extensions/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/component_updater_utils.cc
diff --git a/chrome/browser/component_updater/component_updater_utils.cc b/chrome/browser/component_updater/component_updater_utils.cc
index 051a8e99df31144ed90703f6400bc5ff5914fffc..a3b203804609446489774d3f10fd0b855c671308 100644
--- a/chrome/browser/component_updater/component_updater_utils.cc
+++ b/chrome/browser/component_updater/component_updater_utils.cc
@@ -18,7 +18,6 @@
#include "chrome/browser/component_updater/component_updater_configurator.h"
#include "chrome/browser/component_updater/crx_update_item.h"
#include "components/omaha_query_params/omaha_query_params.h"
-#include "extensions/common/extension.h"
#include "net/base/load_flags.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request_context_getter.h"
@@ -181,7 +180,10 @@ std::string HexStringToID(const std::string& hexstr) {
id.append(1, 'a');
}
}
- DCHECK(extensions::Extension::IdIsValid(id));
+
+ // TODO(tommycli): Add back the DCHECK validating the generated id. This
+ // requires moving the extension id_util functions into components/crx_file.
+
return id;
}
« no previous file with comments | « chrome/browser/component_updater/component_unpacker.cc ('k') | chrome/browser/extensions/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698