Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 474633005: Componentize component_updater: Split crx_file code off into its own component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove shared library export Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/sandboxed_unpacker.h" 5 #include "chrome/browser/extensions/sandboxed_unpacker.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/files/file_util_proxy.h" 13 #include "base/files/file_util_proxy.h"
14 #include "base/files/scoped_file.h" 14 #include "base/files/scoped_file.h"
15 #include "base/json/json_string_value_serializer.h" 15 #include "base/json/json_string_value_serializer.h"
16 #include "base/message_loop/message_loop.h" 16 #include "base/message_loop/message_loop.h"
17 #include "base/metrics/histogram.h" 17 #include "base/metrics/histogram.h"
18 #include "base/numerics/safe_conversions.h" 18 #include "base/numerics/safe_conversions.h"
19 #include "base/path_service.h" 19 #include "base/path_service.h"
20 #include "base/sequenced_task_runner.h" 20 #include "base/sequenced_task_runner.h"
21 #include "base/strings/utf_string_conversions.h" 21 #include "base/strings/utf_string_conversions.h"
22 #include "base/threading/sequenced_worker_pool.h" 22 #include "base/threading/sequenced_worker_pool.h"
23 #include "chrome/browser/extensions/extension_service.h" 23 #include "chrome/browser/extensions/extension_service.h"
24 #include "chrome/common/chrome_paths.h" 24 #include "chrome/common/chrome_paths.h"
25 #include "chrome/common/chrome_switches.h" 25 #include "chrome/common/chrome_switches.h"
26 #include "chrome/common/chrome_utility_messages.h" 26 #include "chrome/common/chrome_utility_messages.h"
27 #include "chrome/common/extensions/chrome_utility_extensions_messages.h" 27 #include "chrome/common/extensions/chrome_utility_extensions_messages.h"
28 #include "chrome/common/extensions/extension_file_util.h" 28 #include "chrome/common/extensions/extension_file_util.h"
29 #include "components/crx_file/constants.h"
30 #include "components/crx_file/crx_file.h"
29 #include "content/public/browser/browser_thread.h" 31 #include "content/public/browser/browser_thread.h"
30 #include "content/public/browser/utility_process_host.h" 32 #include "content/public/browser/utility_process_host.h"
31 #include "content/public/common/common_param_traits.h" 33 #include "content/public/common/common_param_traits.h"
32 #include "crypto/signature_verifier.h" 34 #include "crypto/signature_verifier.h"
33 #include "extensions/common/constants.h" 35 #include "extensions/common/constants.h"
34 #include "extensions/common/crx_file.h"
35 #include "extensions/common/extension.h" 36 #include "extensions/common/extension.h"
36 #include "extensions/common/extension_l10n_util.h" 37 #include "extensions/common/extension_l10n_util.h"
37 #include "extensions/common/file_util.h" 38 #include "extensions/common/file_util.h"
38 #include "extensions/common/id_util.h" 39 #include "extensions/common/id_util.h"
39 #include "extensions/common/manifest_constants.h" 40 #include "extensions/common/manifest_constants.h"
40 #include "extensions/common/manifest_handlers/icons_handler.h" 41 #include "extensions/common/manifest_handlers/icons_handler.h"
41 #include "grit/generated_resources.h" 42 #include "grit/generated_resources.h"
42 #include "third_party/skia/include/core/SkBitmap.h" 43 #include "third_party/skia/include/core/SkBitmap.h"
43 #include "ui/base/l10n/l10n_util.h" 44 #include "ui/base/l10n/l10n_util.h"
44 #include "ui/gfx/codec/png_codec.h" 45 #include "ui/gfx/codec/png_codec.h"
45 46
46 using base::ASCIIToUTF16; 47 using base::ASCIIToUTF16;
47 using content::BrowserThread; 48 using content::BrowserThread;
48 using content::UtilityProcessHost; 49 using content::UtilityProcessHost;
50 using crx_file::CrxFile;
49 51
50 // The following macro makes histograms that record the length of paths 52 // The following macro makes histograms that record the length of paths
51 // in this file much easier to read. 53 // in this file much easier to read.
52 // Windows has a short max path length. If the path length to a 54 // Windows has a short max path length. If the path length to a
53 // file being unpacked from a CRX exceeds the max length, we might 55 // file being unpacked from a CRX exceeds the max length, we might
54 // fail to install. To see if this is happening, see how long the 56 // fail to install. To see if this is happening, see how long the
55 // path to the temp unpack directory is. See crbug.com/69693 . 57 // path to the temp unpack directory is. See crbug.com/69693 .
56 #define PATH_LENGTH_HISTOGRAM(name, path) \ 58 #define PATH_LENGTH_HISTOGRAM(name, path) \
57 UMA_HISTOGRAM_CUSTOM_COUNTS(name, path.value().length(), 0, 500, 100) 59 UMA_HISTOGRAM_CUSTOM_COUNTS(name, path.value().length(), 0, 500, 100)
58 60
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 // Invalid signature 538 // Invalid signature
537 ReportFailure( 539 ReportFailure(
538 CRX_SIGNATURE_INVALID, 540 CRX_SIGNATURE_INVALID,
539 l10n_util::GetStringFUTF16( 541 l10n_util::GetStringFUTF16(
540 IDS_EXTENSION_PACKAGE_ERROR_CODE, 542 IDS_EXTENSION_PACKAGE_ERROR_CODE,
541 ASCIIToUTF16("CRX_SIGNATURE_INVALID"))); 543 ASCIIToUTF16("CRX_SIGNATURE_INVALID")));
542 return false; 544 return false;
543 } 545 }
544 546
545 crypto::SignatureVerifier verifier; 547 crypto::SignatureVerifier verifier;
546 if (!verifier.VerifyInit(extension_misc::kSignatureAlgorithm, 548 if (!verifier.VerifyInit(crx_file::kSignatureAlgorithm,
547 sizeof(extension_misc::kSignatureAlgorithm), 549 sizeof(crx_file::kSignatureAlgorithm),
548 &signature.front(), 550 &signature.front(),
549 signature.size(), 551 signature.size(),
550 &key.front(), 552 &key.front(),
551 key.size())) { 553 key.size())) {
552 // Signature verification initialization failed. This is most likely 554 // Signature verification initialization failed. This is most likely
553 // caused by a public key in the wrong format (should encode algorithm). 555 // caused by a public key in the wrong format (should encode algorithm).
554 ReportFailure( 556 ReportFailure(
555 CRX_SIGNATURE_VERIFICATION_INITIALIZATION_FAILED, 557 CRX_SIGNATURE_VERIFICATION_INITIALIZATION_FAILED,
556 l10n_util::GetStringFUTF16( 558 l10n_util::GetStringFUTF16(
557 IDS_EXTENSION_PACKAGE_ERROR_CODE, 559 IDS_EXTENSION_PACKAGE_ERROR_CODE,
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 830
829 void SandboxedUnpacker::Cleanup() { 831 void SandboxedUnpacker::Cleanup() {
830 DCHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread()); 832 DCHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
831 if (!temp_dir_.Delete()) { 833 if (!temp_dir_.Delete()) {
832 LOG(WARNING) << "Can not delete temp directory at " 834 LOG(WARNING) << "Can not delete temp directory at "
833 << temp_dir_.path().value(); 835 << temp_dir_.path().value();
834 } 836 }
835 } 837 }
836 838
837 } // namespace extensions 839 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698