Optional binary payloads in VM service events.

runtime/bin/vmservice/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] is an object known to the VM service and is tied
 /// to an owning [Isolate].
 abstract class ServiceObject extends Observable {
   static int LexicalSortName(ServiceObject o1, ServiceObject o2) {
@@ skipping 235 matching lines @@
     update(toObservable({'id':'vm', 'type':'@VM'}));
   }
 
   final StreamController<ServiceException> exceptions =
       new StreamController.broadcast();
   final StreamController<ServiceError> errors =
       new StreamController.broadcast();
   final StreamController<ServiceEvent> events =
       new StreamController.broadcast();
 
-  void postEventMessage(String eventMessage) {
+  void postEventMessage(dynamic eventMessage, [dynamic data]) {

[Cutch, 2014/08/15 21:33:58]

Is eventMessage actually dynamic now?

[koda, 2014/08/15 22:20:53]

Already fixed in the later patch set.

       var map;
       try {
         map = _parseJSON(eventMessage);
+        if (data != null) {
+          assert(!map.containsKey('_data'));
+          map['_data'] = data;
+        }
       } catch (e, st) {
         Logger.root.severe('Ignoring malformed event message: ${eventMessage}');
         return;
       }
       if (map['type'] != 'ServiceEvent') {
         Logger.root.severe(
             "Expected 'ServiceEvent' but found '${map['type']}'");
         return;
       }
 
@@ skipping 890 matching lines @@
   }
 }
 
 /// A [ServiceEvent] is an asynchronous event notification from the vm.
 class ServiceEvent extends ServiceObject {
   ServiceEvent._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   @observable String eventType;
   @observable ServiceMap breakpoint;
   @observable ServiceMap exception;
+  @observable ByteData data;
 
   void _update(ObservableMap map, bool mapIsRef) {
     _loaded = true;
     _upgradeCollection(map, owner);
     eventType = map['eventType'];
     name = 'ServiceEvent $eventType';
     vmName = name;
     if (map['breakpoint'] != null) {
       breakpoint = map['breakpoint'];
     }
     if (map['exception'] != null) {
       exception = map['exception'];
     }
+    if (map['_data'] != null) {
+      data = map['_data'];
+    }
+  }
+  
+  String toString() {
+    return 'ServiceEvent of type $eventType with '
+        '${data == null ? 0 : data.lengthInBytes} bytes of binary data';
   }
 }
 
 class Library extends ServiceObject with Coverage {
   @observable String url;
   @reflectable final imports = new ObservableList<Library>();
   @reflectable final scripts = new ObservableList<Script>();
   @reflectable final classes = new ObservableList<Class>();
   @reflectable final variables = new ObservableList<ServiceMap>();
   @reflectable final functions = new ObservableList<ServiceFunction>();
@@ skipping 1050 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }