Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py

Issue 474613002: telemetry: Fix TracingCategoryFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Raise assertion when both included and excluded. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/platform/tracing_category_filter.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py
diff --git a/tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py b/tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py
index 3780de0f3ffb85d68bcd816e2b2b307066d51e4a..f6a7f406602bea75d4bca253b63626b26a0a0bb0 100644
--- a/tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/tracing_category_filter_unittest.py
@@ -24,6 +24,36 @@ class TracingCategoryFilterTests(unittest.TestCase):
class CategoryFilterTest(unittest.TestCase):
+ def testAddIncludedCategory(self):
+ a = tracing_category_filter.TracingCategoryFilter()
+ a.AddIncludedCategory('foo')
+ a.AddIncludedCategory('bar')
+ a.AddIncludedCategory('foo')
+ self.assertEquals(a.stable_filter_string, 'bar,foo')
+
+ def testAddExcludedCategory(self):
+ a = tracing_category_filter.TracingCategoryFilter()
+ a.AddExcludedCategory('foo')
+ a.AddExcludedCategory('bar')
+ a.AddExcludedCategory('foo')
+ self.assertEquals(a.stable_filter_string, '-bar,-foo')
+
+ def testIncludeAndExcludeCategoryRaisesAssertion(self):
+ a = tracing_category_filter.TracingCategoryFilter()
+ a.AddIncludedCategory('foo')
+ self.assertRaises(AssertionError, a.AddExcludedCategory, 'foo')
+
+ a = tracing_category_filter.TracingCategoryFilter()
+ a.AddExcludedCategory('foo')
+ self.assertRaises(AssertionError, a.AddIncludedCategory, 'foo')
+
+ self.assertRaises(AssertionError,
+ tracing_category_filter.TracingCategoryFilter, 'foo,-foo')
+
+ self.assertRaises(AssertionError,
+ tracing_category_filter.TracingCategoryFilter, '-foo,foo')
+
+
def testIsSubset(self):
b = tracing_category_filter.TracingCategoryFilter()
a = tracing_category_filter.TracingCategoryFilter()
« no previous file with comments | « tools/telemetry/telemetry/core/platform/tracing_category_filter.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698