Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 474603002: Obtain user's profile correctly in UserImageSyncObserver. (Closed)

Created:
6 years, 4 months ago by dzhioev (left Google)
Modified:
6 years, 4 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Obtain user's profile correctly in UserImageSyncObserver. UserImageSyncObserver obtained profile in a strange and wrong way. Now it uses GetProfileByUser. BUG=NONE TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 4 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dzhioev (left Google)
6 years, 4 months ago (2014-08-13 20:32:48 UTC) #1
Alexander Alekseev
lgtm
6 years, 4 months ago (2014-08-13 23:53:44 UTC) #2
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 4 months ago (2014-08-13 23:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/474603002/1
6 years, 4 months ago (2014-08-13 23:58:46 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 09:54:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289506

Powered by Google App Engine
This is Rietveld 408576698