content::WebServiceWorkerCache implementation.

content/common/service_worker/service_worker_types.h

Index: content/common/service_worker/service_worker_types.h
diff --git a/content/common/service_worker/service_worker_types.h b/content/common/service_worker/service_worker_types.h
index de582e432d757f2c33d3a4f2548328d44fc4f61d..44a03e2d64dc9b7e9a4ef49f2ad7fdb2ab603a2e 100644
--- a/content/common/service_worker/service_worker_types.h
+++ b/content/common/service_worker/service_worker_types.h
@@ -76,6 +76,37 @@ struct CONTENT_EXPORT ServiceWorkerResponse {
   std::string blob_uuid;
 };
 
+// In the Cache API this struct controls the operation of matching in operations

[dominicc (has gone to gerrit), 2014/08/15 06:48:35]

This is repetitively repetitious ... the operation of operations; the matching
that matches; "this struct"... what else would it refer to?

How about:

Controls how requests are matched in the Cache API.

Maybe comments below can be tightened up too.

[gavinp, 2014/09/03 18:35:24]

Done.

+// that match requests to each other.
+struct CONTENT_EXPORT ServiceWorkerCacheQueryParams {
+  ServiceWorkerCacheQueryParams();
+
+  bool ignore_search;
+  bool ignore_method;
+  bool ignore_vary;
+  bool prefix_match;
+};
+
+// In the Cache API this describes the type of an individual operation, used as
+// part of the BatchOperation struct.
+enum ServiceWorkerCacheOperationType {
+  SERVICE_WORKER_CACHE_OPERATION_TYPE_UNDEFINED,
+  SERVICE_WORKER_CACHE_OPERATION_TYPE_PUT,
+  SERVICE_WORKER_CACHE_OPERATION_TYPE_DELETE,
+  SERVICE_WORKER_CACHE_OPERATION_TYPE_LAST =
+      SERVICE_WORKER_CACHE_OPERATION_TYPE_DELETE
+};
+
+// In the Cache API, this struct describes a single operation of PUT or DELETE.

[dominicc (has gone to gerrit), 2014/08/15 06:48:35]

Why all caps for put and delete? These look like HTTP methods, which are
cursorily related (cache, requests, methods) so its confusing to have them it
caps.

[gavinp, 2014/09/03 18:35:24]

"Though the Google C++ Style Guide now says to use kConstantNaming for enums,
Chromium was written using MACRO_STYLE naming.  Continue to use this style for
consistency."

http://www.chromium.org/developers/coding-style

+struct CONTENT_EXPORT ServiceWorkerBatchOperation {
+  ServiceWorkerBatchOperation();
+
+  ServiceWorkerCacheOperationType operation_type;
+  ServiceWorkerFetchRequest request;
+  ServiceWorkerResponse response;
+  ServiceWorkerCacheQueryParams match_params;
+};
+
 // Represents initialization info for a WebServiceWorker object.
 struct CONTENT_EXPORT ServiceWorkerObjectInfo {
   ServiceWorkerObjectInfo();