Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 474563004: Profile mojom: change some fields to nullable according to documentation. (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Profile mojom: change some fields to nullable according to documentation. BUG=324170 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291363

Patch Set 1 #

Patch Set 2 : delete the file as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M mojo/services/public/interfaces/profile/profile_service.mojom View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Benjamin. Would you please take a look? thanks!
6 years, 4 months ago (2014-08-21 18:14:53 UTC) #1
darin (slow to review)
I think we can delete this mojom file actually. It is orphaned and should have ...
6 years, 4 months ago (2014-08-21 23:48:55 UTC) #2
yzshen1
On 2014/08/21 23:48:55, darin wrote: > I think we can delete this mojom file actually. ...
6 years, 4 months ago (2014-08-22 00:01:32 UTC) #3
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-22 05:24:33 UTC) #4
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-22 06:35:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/474563004/20001
6 years, 4 months ago (2014-08-22 06:36:12 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 07:51:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291363

Powered by Google App Engine
This is Rietveld 408576698