Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 47453002: Add UseCounter for TextTrackCue constructor (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, vcarbune.chromium, philipj_slow, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add UseCounter for TextTrackCue constructor The plan in issue 270340 is to leave the TextTrackCue constructor until it is known to be safe to deprecate and remove. Add a UseCounter so that we can get stats from M32 stable, to be branched Nov 4th, 2013. BUG=270340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/html/track/TextTrackCue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
Glenn, perhaps you've already done this, but in case 270340 isn't landed before the branch ...
7 years, 1 month ago (2013-10-27 10:50:48 UTC) #1
nessy
Great idea - getting these numbers is important.
7 years, 1 month ago (2013-10-27 11:30:38 UTC) #2
vcarbune.chromium
Not my review, but I also support this. lgtm On Oct 27, 2013 4:30 AM, ...
7 years, 1 month ago (2013-10-27 14:09:05 UTC) #3
gasubic
lgtm
7 years, 1 month ago (2013-10-27 14:36:54 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-10-28 08:11:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/47453002/1
7 years, 1 month ago (2013-10-28 08:18:02 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 09:31:40 UTC) #7
Message was sent while issue was closed.
Change committed as 160707

Powered by Google App Engine
This is Rietveld 408576698