Enable command line arguments for GLES2 CTS.

Enable command line arguments for GLES2 CTS.

This will enable us to select the back-end renderer for ANGLE.

BUG=380355
Committed: https://crrev.com/da247005b23868a580014fd368686dd5b3171c4e
Cr-Commit-Position: refs/heads/master@{#292634}

[Jamie Madill, 2014-08-26 17:27:11]

jmadill@chromium.org changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[Jamie Madill, 2014-08-26 17:27:52]

Please take a look. I plan on using the new command line arguments to pass
--disable-d3d11 to the EGL layer for use in the GPU recipe.

[Ken Russell (switch to Gerrit), 2014-08-26 17:41:08]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-08-26 17:41:08]

LGTM as long as this has been tested.

[Jamie Madill, 2014-08-26 17:47:02]

I did tests myself using printf-style debugging and verified I can create a D3D9
Renderer with ANGLE and the GLES2 tests.

Do I need a LGTM from sievers or piman since gpu/gles2_conform/support doesn't
have a specific owner and they own src/gpu?

[Ken Russell (switch to Gerrit), 2014-08-26 18:20:28]

On 2014/08/26 17:47:02, Jamie Madill wrote:
> I did tests myself using printf-style debugging and verified I can create a
D3D9
> Renderer with ANGLE and the GLES2 tests.
> 
> Do I need a LGTM from sievers or piman since gpu/gles2_conform/support doesn't
> have a specific owner and they own src/gpu?

Yes. If you can't find them online then feel free to TBR= this to them.

[piman, 2014-08-26 18:57:07]

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
File gpu/gles2_conform_support/native/main.cc (right):

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
gpu/gles2_conform_support/native/main.cc:36: char const** argsArray = new const
char *[args.size()];
nit: scoped_ptr<char const*[]>
nit: new const char*[args.size()];  (star on the left)

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
gpu/gles2_conform_support/native/main.cc:42: argsArray[index] =
argsNonWide[index].c_str();
I'm not sure that's safe. when you push_back a new string, it may reallocate the
backing for argsNonWide, which would copy the underlying strings. I don't think
we have a guarantee that if the string is copied, the c_str() would still be
valid.

[Jamie Madill, 2014-08-26 19:29:54]

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
File gpu/gles2_conform_support/native/main.cc (right):

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
gpu/gles2_conform_support/native/main.cc:36: char const** argsArray = new const
char *[args.size()];
On 2014/08/26 18:57:07, piman (OOO) wrote:
> nit: scoped_ptr<char const*[]>
> nit: new const char*[args.size()];  (star on the left)

Done.

https://codereview.chromium.org/474523003/diff/40001/gpu/gles2_conform_suppor...
gpu/gles2_conform_support/native/main.cc:42: argsArray[index] =
argsNonWide[index].c_str();
On 2014/08/26 18:57:07, piman (OOO) wrote:
> I'm not sure that's safe. when you push_back a new string, it may reallocate
the
> backing for argsNonWide, which would copy the underlying strings. I don't
think
> we have a guarantee that if the string is copied, the c_str() would still be
> valid.

Good point. I split the operation into two loops.

[piman, 2014-08-26 20:46:41]

LGTM (another way is to pre-size the vector, but either way is fine).

[Jamie Madill, 2014-08-27 15:41:00]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:41:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmadill@chromium.org/474523003/80001

[Jamie Madill, 2014-08-27 15:54:16]

The CQ bit was unchecked by jmadill@chromium.org

[Jamie Madill, 2014-08-29 14:14:00]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2014-08-29 14:14:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmadill@chromium.org/474523003/100001

[commit-bot: I haz the power, 2014-08-29 15:10:29]

Committed patchset #6 (id:100001) as 042488de16a98c3cb5ef3c01967dfb24bcf1a4bd

[commit-bot: I haz the power, 2014-09-10 03:08:40]

Patchset 6 (id:??) landed as
https://crrev.com/da247005b23868a580014fd368686dd5b3171c4e
Cr-Commit-Position: refs/heads/master@{#292634}