Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 474493003: Fixing small error with is_distilable_trigger.js (Closed)

Created:
6 years, 4 months ago by smaslo
Modified:
6 years, 4 months ago
Reviewers:
nyquist, Yaron
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fixing small error with is_distilable_trigger.js Removing backslash that would cause JavaScript error. BUG=383630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289527

Patch Set 1 #

Patch Set 2 : Auto Bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/dom_distiller/core/javascript/is_distillable_trigger.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
smaslo
6 years, 4 months ago (2014-08-13 17:28:40 UTC) #1
Yaron
lgtm
6 years, 4 months ago (2014-08-13 17:30:03 UTC) #2
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-13 17:31:56 UTC) #3
smaslo
The CQ bit was unchecked by smaslo@chromium.org
6 years, 4 months ago (2014-08-13 17:32:00 UTC) #4
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-13 17:42:42 UTC) #5
smaslo
The CQ bit was unchecked by smaslo@chromium.org
6 years, 4 months ago (2014-08-13 17:42:45 UTC) #6
nyquist
lgtm
6 years, 4 months ago (2014-08-13 17:51:05 UTC) #7
smaslo
The CQ bit was checked by smaslo@chromium.org
6 years, 4 months ago (2014-08-13 17:51:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smaslo@chromium.org/474493003/1
6 years, 4 months ago (2014-08-13 17:53:02 UTC) #9
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-13 23:58:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/smaslo@chromium.org/474493003/20001
6 years, 4 months ago (2014-08-14 00:03:07 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-14 09:44:11 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 11:27:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289527

Powered by Google App Engine
This is Rietveld 408576698