trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc - Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc

Issue 474483002: Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc ('k') | trunk/src/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc

===================================================================

--- trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc (revision 289319)

+++ trunk/src/components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc (working copy)

@@ -306,14 +306,11 @@

std::string IMAGE = "image/";

size_t mime_type_size = mime_type.size();

- if ((mime_type_size >= JS1.size() &&

- base::LowerCaseEqualsASCII(mime_type.begin(),

+ if ((mime_type_size >= JS1.size() && LowerCaseEqualsASCII(mime_type.begin(),

mime_type.begin() + JS1.size(), JS1.c_str())) ||

- (mime_type_size >= JS2.size() &&

- base::LowerCaseEqualsASCII(mime_type.begin(),

+ (mime_type_size >= JS2.size() && LowerCaseEqualsASCII(mime_type.begin(),

mime_type.begin() + JS2.size(), JS2.c_str())) ||

- (mime_type_size >= JS3.size() &&

- base::LowerCaseEqualsASCII(mime_type.begin(),

+ (mime_type_size >= JS3.size() && LowerCaseEqualsASCII(mime_type.begin(),

mime_type.begin() + JS3.size(), JS3.c_str()))) {

REPORT_TAMPER_DETECTION_UMA(

scheme_is_https_,

@@ -321,7 +318,7 @@

"DataReductionProxy.HeaderTamperedHTTP_ContentLength_JS",

carrier_id_);

} else if (mime_type_size >= CSS.size() &&

- base::LowerCaseEqualsASCII(mime_type.begin(),

+ LowerCaseEqualsASCII(mime_type.begin(),

mime_type.begin() + CSS.size(), CSS.c_str())) {

REPORT_TAMPER_DETECTION_UMA(

scheme_is_https_,

@@ -329,7 +326,7 @@

"DataReductionProxy.HeaderTamperedHTTP_ContentLength_CSS",

carrier_id_);

} else if (mime_type_size >= IMAGE.size() &&

- base::LowerCaseEqualsASCII(mime_type.begin(),

+ LowerCaseEqualsASCII(mime_type.begin(),

mime_type.begin() + IMAGE.size(), IMAGE.c_str())) {

REPORT_TAMPER_DETECTION_UMA(

scheme_is_https_,