Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 474473002: Expose full userinfo to callers of GaiaOAuthFetcher. (Closed)

Created:
6 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Expose full userinfo to callers of GaiaOAuthFetcher. BUG=341408 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289449

Patch Set 1 #

Patch Set 2 : fix line ends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -21 lines) Patch
M google_apis/gaia/gaia_constants.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 5 chunks +34 lines, -13 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 5 chunks +51 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Xiyuan, Can you take a look please? This is exposing GetUserInfo() to callers. I'll ...
6 years, 4 months ago (2014-08-13 17:30:05 UTC) #1
xiyuan
lgtm
6 years, 4 months ago (2014-08-13 17:38:24 UTC) #2
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 4 months ago (2014-08-13 20:19:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/474473002/20001
6 years, 4 months ago (2014-08-13 20:21:31 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 03:17:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289449

Powered by Google App Engine
This is Rietveld 408576698