win: Add /Zc:inline to Pro Release builds

win: Add /Zc:inline to Pro Release builds

http://msdn.microsoft.com/en-us/library/dn642448.aspx

This makes Release .objs smaller and so links faster. It was added in
Update 2, but caused the compiler to crash on Chrome building LTCG. It
seems to be OK after Update 3.

As the depot_tools Express toolchain is not yet Update 3, we don't add
the flag there.

R=jam@chromium.org
BUG=350018, 402270
Committed: https://crrev.com/4f828c94f2875e6e66fbec71c34ef088f5099522
Cr-Commit-Position: refs/heads/master@{#292571}

[jam, 2014-08-13 21:40:53]

lgtm, thanks for helping out on the compile speed!

Do you have timing on how much faster this is? it would be helpful to know from
the perspective of the code yellow.

[scottmg, 2014-08-13 21:42:37]

On 2014/08/13 21:40:53, jam wrote:
> lgtm, thanks for helping out on the compile speed!
> 
> Do you have timing on how much faster this is? it would be helpful to know
from
> the perspective of the code yellow.

Linking got 17% faster on Release build on Z620. We'll have to watch the cycle
speed once this lands as it's hard to say how it will affect performance there
because of goma, different IO speed, etc.

[scottmg, 2014-08-14 18:49:47]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-14 18:52:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/474463002/1

[scottmg, 2014-08-14 22:11:48]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2014-08-14 22:11:54]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-14 22:14:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/474463002/1

[scottmg, 2014-08-15 00:13:03]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2014-08-15 00:13:32]

Had to revert the Update3 roll, sigh. This will have to wait until that can land
again, but it looks like there's a new compiler bug.

[scottmg, 2014-08-21 21:00:59]

On 2014/08/15 00:13:32, scottmg wrote:
> Had to revert the Update3 roll, sigh. This will have to wait until that can
land
> again, but it looks like there's a new compiler bug.

Not sure why, but apparently Update 3 is ok now. Perhaps it was related to
flakiness goma was having last time we tried? So I'm going to try to reland
this.

[scottmg, 2014-08-21 21:01:04]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:05:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/474463002/1

[commit-bot: I haz the power, 2014-08-21 22:10:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 22:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 22:53:14]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2014-08-28 20:47:10]

Patchset #3 (id:40001) has been deleted

[scottmg, 2014-08-28 20:47:13]

Patchset #2 (id:20001) has been deleted

[scottmg, 2014-08-29 02:54:33]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-29 02:55:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/474463002/1

[commit-bot: I haz the power, 2014-08-29 04:11:13]

Committed patchset #1 (id:1) as 62c2cf550f96e0cfe09355624a3204b88fb86023

[commit-bot: I haz the power, 2014-09-10 03:06:15]

Patchset 1 (id:??) landed as
https://crrev.com/4f828c94f2875e6e66fbec71c34ef088f5099522
Cr-Commit-Position: refs/heads/master@{#292571}