Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 474433004: DevTools: [SSP] show source location for the newly inserted style rules. (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] show source location for the newly inserted style rules. To achieve the specified goal, the patch does the following: - StylePropertiesSection.styleRule no longer has sourceURL as it could be always fetched from styleRule.rule - StylePropertiesSection._createRuleOrigin is receiving CSSRule and ruleLocation as arguments - BlankStylePropertiesSection is taught to infer the actual rule location of the rule that will be inserted Layout Test change: the CSSOM rule now don't show source location (used to be "located" on first line) R=pfeldman, vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180348

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 1

Patch Set 3 : type safety via WebInspector.CSSRuleSelector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -35 lines) Patch
M LayoutTests/inspector/elements/styles/cssom-media-insert-crash-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 12 chunks +68 lines, -24 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 1 2 3 chunks +41 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-14 19:59:05 UTC) #1
apavlov
lgtm with a comment https://codereview.chromium.org/474433004/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/474433004/diff/20001/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1936 Source/devtools/front_end/elements/StylesSidebarPane.js:1936: var editRange = new WebInspector.TextRange(0, ...
6 years, 4 months ago (2014-08-15 08:29:38 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 08:40:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/474433004/20001
6 years, 4 months ago (2014-08-15 08:41:38 UTC) #4
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 08:47:23 UTC) #5
apavlov
lgtm
6 years, 4 months ago (2014-08-15 09:40:25 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-15 09:40:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/474433004/30003
6 years, 4 months ago (2014-08-15 09:41:47 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 10:40:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (30003) as 180348

Powered by Google App Engine
This is Rietveld 408576698