Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: content/browser/geolocation/wifi_data_provider_common_unittest.cc

Issue 474433003: Cleaner organization of WifiDataProvider code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rabase and rename arguments to manager Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/wifi_data_provider_common_unittest.cc
diff --git a/content/browser/geolocation/wifi_data_provider_common_unittest.cc b/content/browser/geolocation/wifi_data_provider_common_unittest.cc
index 7b583f2f4e7d759162b50748a5b1d7b3023345d6..d6a3b0862724e37bcfd427c2aabc10a9d021ce56 100644
--- a/content/browser/geolocation/wifi_data_provider_common_unittest.cc
+++ b/content/browser/geolocation/wifi_data_provider_common_unittest.cc
@@ -9,6 +9,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/third_party/dynamic_annotations/dynamic_annotations.h"
#include "content/browser/geolocation/wifi_data_provider_common.h"
+#include "content/browser/geolocation/wifi_data_provider_manager.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -67,13 +68,13 @@ class MessageLoopQuitter {
CHECK(message_loop_to_quit_ != NULL);
}
- void OnWifiDataUpdate(WifiDataProvider* provider) {
+ void OnWifiDataUpdate(WifiDataProviderManager* manager) {
// Provider should call back on client's thread.
EXPECT_EQ(base::MessageLoop::current(), message_loop_to_quit_);
message_loop_to_quit_->QuitNow();
}
base::MessageLoop* message_loop_to_quit_;
- WifiDataProvider::WifiDataUpdateCallback callback_;
+ WifiDataProviderManager::WifiDataUpdateCallback callback_;
};
class WifiDataProviderCommonWithMock : public WifiDataProviderCommon {
@@ -101,7 +102,7 @@ class WifiDataProviderCommonWithMock : public WifiDataProviderCommon {
DISALLOW_COPY_AND_ASSIGN(WifiDataProviderCommonWithMock);
};
-WifiDataProviderImplBase* CreateWifiDataProviderCommonWithMock() {
+WifiDataProvider* CreateWifiDataProviderCommonWithMock() {
return new WifiDataProviderCommonWithMock;
}
@@ -218,11 +219,11 @@ TEST_F(GeolocationWifiDataProviderCommonTest, DoScanWithResults) {
TEST_F(GeolocationWifiDataProviderCommonTest, RegisterUnregister) {
MessageLoopQuitter loop_quitter(&main_message_loop_);
- WifiDataProvider::SetFactory(CreateWifiDataProviderCommonWithMock);
- WifiDataProvider::Register(&loop_quitter.callback_);
+ WifiDataProviderManager::SetFactory(CreateWifiDataProviderCommonWithMock);
+ WifiDataProviderManager::Register(&loop_quitter.callback_);
main_message_loop_.Run();
- WifiDataProvider::Unregister(&loop_quitter.callback_);
- WifiDataProvider::ResetFactory();
+ WifiDataProviderManager::Unregister(&loop_quitter.callback_);
+ WifiDataProviderManager::ResetFactory();
}
} // namespace content
« no previous file with comments | « content/browser/geolocation/wifi_data_provider_common.h ('k') | content/browser/geolocation/wifi_data_provider_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698