Issue 474433003: Cleaner organization of WifiDataProvider code.

Issue 474433003: Cleaner organization of WifiDataProvider code. (Closed)

Created:
6 years, 4 months ago by Michael van Ouwerkerk

Modified:
6 years, 4 months ago

Reviewers:
timvolodine

CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleaner organization of WifiDataProvider code. * Rename WifiDataProvider to WifiDataProviderManager * Rename WifiDataProviderImplBase to WifiDataProvider * Split these into separate files Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290586

Patch Set 1 #

Patch Set 2 : Rebase and use similarity=30 #

Patch Set 3 : Fix unit test compilation. #

Total comments: 4

Patch Set 4 : Rabase and rename arguments to manager #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -397 lines)			Patch
M	content/browser/geolocation/empty_wifi_data_provider.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/empty_wifi_data_provider.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/geolocation/network_location_provider.h	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/geolocation/network_location_provider.cc	View	1 2 3	7 chunks	+12 lines, -10 lines	0 comments	Download
M	content/browser/geolocation/network_location_provider_unittest.cc	View	1 2	6 chunks	+16 lines, -22 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider.h	View		6 chunks	+10 lines, -88 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider.cc	View		2 chunks	+13 lines, -103 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_chromeos.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_chromeos.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_common.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_common_unittest.cc	View	1 2	4 chunks	+8 lines, -7 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_linux.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_mac.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
A +	content/browser/geolocation/wifi_data_provider_manager.h	View	1	4 chunks	+18 lines, -83 lines	0 comments	Download
A +	content/browser/geolocation/wifi_data_provider_manager.cc	View	1	3 chunks	+20 lines, -67 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_win.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/content_browser.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

Hi Tim, this is a followup on top of: https://codereview.chromium.org/477633002/

6 years, 4 months ago (2014-08-14 17:21:15 UTC) #1

Michael van Ouwerkerk

Hi Tim, I reuploaded it with similarity=30 so it's easier to see what has and ...

6 years, 4 months ago (2014-08-15 14:28:32 UTC) #2

timvolodine

lgtm, looks like you managed to get rid of quite some lines of code :) ...

6 years, 4 months ago (2014-08-18 15:21:43 UTC) #3

Michael van Ouwerkerk

Thanks Tim! https://codereview.chromium.org/474433003/diff/40001/content/browser/geolocation/network_location_provider.cc File content/browser/geolocation/network_location_provider.cc (right): https://codereview.chromium.org/474433003/diff/40001/content/browser/geolocation/network_location_provider.cc#newcode158 content/browser/geolocation/network_location_provider.cc:158: WifiDataProviderManager* provider) { On 2014/08/18 15:21:42, timvolodine ...

6 years, 4 months ago (2014-08-19 13:02:39 UTC) #4

Michael van Ouwerkerk

The CQ bit was checked by mvanouwerkerk@chromium.org

6 years, 4 months ago (2014-08-19 13:04:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/474433003/60001

6 years, 4 months ago (2014-08-19 13:05:35 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-19 14:30:32 UTC) #7

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 16:20:47 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 (60001) as 290586

Expand Messages | Collapse Messages