Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 47443002: Added prefixLength to the items in the result of a getNetworkList. This allows the broadcast addres… (Closed)

Created:
7 years, 1 month ago by ianet
Modified:
7 years, 1 month ago
Reviewers:
miket_OOO, scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, thorogood
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added prefixLength to the items in the result of a getNetworkList. This allows the broadcast address to be calculated. BUG=149057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/api/socket/socket_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/socket.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ianet
7 years, 1 month ago (2013-10-28 16:55:56 UTC) #1
miket_OOO
LGTM. Would it make sense to make the parameter optional? I don't think so because ...
7 years, 1 month ago (2013-10-28 19:46:06 UTC) #2
scheib
lgtm
7 years, 1 month ago (2013-11-05 04:08:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianet@chromium.org/47443002/1
7 years, 1 month ago (2013-11-05 04:15:51 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 05:12:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianet@chromium.org/47443002/1
7 years, 1 month ago (2013-11-05 17:10:48 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 19:10:23 UTC) #7
Message was sent while issue was closed.
Change committed as 233045

Powered by Google App Engine
This is Rietveld 408576698