Issue 474383002: Chromoting: Use different jscompile stamp files for v1 and v2 webapps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474383002: Chromoting: Use different jscompile stamp files for v1 and v2 webapps. (Closed)

Created:
6 years, 4 months ago by garykac

Modified:
6 years, 4 months ago

Reviewers:
Jamie

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Chromoting: Use different jscompile stamp files for v1 and v2 webapps. Currently, both the v1 and the v2 webapps use the same stamp file for their jscompile actions. The result of this is that the jscompile checks will only be run for either v1 or v2, but not both. This change derives the jscompile.stamp file from the target name so that each webapp has its own stamp file. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290137

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/remoting_webapp.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/474383002/1

6 years, 4 months ago (2014-08-16 01:23:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290137

Expand Messages | Collapse Messages