Issue 474353004: FileReader: switch to using TypeChecking=Interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474353004: FileReader: switch to using TypeChecking=Interface (Closed)

Created:
6 years, 4 months ago by sof

Modified:
6 years, 4 months ago

Reviewers:
haraken, Jens Widell, nhiroki, tzik

CC:
blink-reviews, Inactive, arv+blink, kinuko+fileapi, nhiroki, tzik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

FileReader: switch to using TypeChecking=Interface Let generated bindings code handle the type checking of Blob arguments. R=tzik@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180454

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -37 lines)			Patch
M	LayoutTests/fast/files/file-reader-methods-illegal-arguments-expected.txt	View	1 chunk	+16 lines, -16 lines	0 comments	Download
M	Source/core/fileapi/FileReader.cpp	View	4 chunks	+4 lines, -20 lines	0 comments	Download
M	Source/core/fileapi/FileReader.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/474353004/1

6 years, 4 months ago (2014-08-18 12:10:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180454