Correct order for alignment in name iterator record.

Correct order for alignment in name iterator record.

We must be quite careful about the order of fields in a 'pragma pack(1)'.
On Android the order 'uint16_t, void*' will misalign the pointer,
potentially leading to a crash.

In the future we should move anything which is not strictly part of the
table definition outside of the packed region.

Committed: https://skia.googlesource.com/skia/+/0a25b2ccf850ea41f3b083422f0420822832c540

[bungeman-skia, 2014-08-15 19:37:23]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-08-15 19:37:51]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/474313002/1

[commit-bot: I haz the power, 2014-08-15 19:37:52]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-16 01:37 UTC

[mtklein, 2014-08-15 19:45:06]

lgtm

https://codereview.chromium.org/474313002/diff/1/src/sfnt/SkOTTable_name.h
File src/sfnt/SkOTTable_name.h (right):

https://codereview.chromium.org/474313002/diff/1/src/sfnt/SkOTTable_name.h#ne...
src/sfnt/SkOTTable_name.h:550: class Iterator {
Follow up by moving the Iterator out?

[commit-bot: I haz the power, 2014-08-18 15:07:50]

Committed patchset #1 (1) as 0a25b2ccf850ea41f3b083422f0420822832c540