Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 474293007: Docserver: Automatically implement FileSystem.Stat if FileSystem.StatAsync has (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Docserver: Automatically implement FileSystem.Stat if FileSystem.StatAsync has been implemented. R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/common/extensions/docs/server2/caching_file_system.py View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/file_system.py View 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/gitiles_file_system.py View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/subversion_file_system.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
6 years, 4 months ago (2014-08-21 21:16:34 UTC) #1
Yoyo Zhou
LGTM but looks like a bandaid
6 years, 4 months ago (2014-08-21 21:56:28 UTC) #2
not at google - send to devlin
On 2014/08/21 21:56:28, Yoyo Zhou wrote: > LGTM but looks like a bandaid Yeah it ...
6 years, 4 months ago (2014-08-21 22:07:12 UTC) #3
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 4 months ago (2014-08-21 22:07:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/474293007/1
6 years, 4 months ago (2014-08-21 22:08:14 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:28:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 291297

Powered by Google App Engine
This is Rietveld 408576698